[OCPCLOUD-1070] Set --cloud-provider=external for supported platforms by Danil-Grigorev · Pull Request #450 · openshift/cluster-kube-controller-manager-operator

Danil-Grigorev · 2020-09-16T14:17:54Z

Includes revendoring after openshift/library-go#895 and openshift/library-go#1077 changes are merged. Requires for KCM to apply --cloud-provider=external flag on supported platforms.

openshift-ci-robot · 2020-09-17T19:40:26Z

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`94b91f5`	link	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2020-09-25T18:43:38Z

@Danil-Grigorev: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-24T22:59:48Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-01-24T00:53:04Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-ci-robot · 2021-02-17T13:54:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Danil-Grigorev
To complete the pull request process, please assign ingvagabund after the PR has been reviewed.
You can assign the PR to them by writing /assign @ingvagabund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-14T12:42:48Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot · 2021-04-14T12:42:59Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Danil-Grigorev · 2021-06-29T12:40:37Z

/open

This is still very much required change.

Danil-Grigorev · 2021-06-29T12:43:08Z

/reopen

openshift-ci · 2021-06-29T12:43:16Z

@Danil-Grigorev: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Danil-Grigorev · 2021-06-29T12:43:27Z

/remove-lifecycle rotten

elmiko

confused about the replace in the go.mod

go.mod

JoelSpeed · 2021-07-02T11:02:33Z

IIUC, this revendor works because KCMO uses library go utilities (cloudprovider observer) already, so we just need to make sure it's using the latest version of that?

Danil-Grigorev · 2021-07-02T11:13:00Z

IIUC, this revendor works because KCMO uses library go utilities (cloudprovider observer) already, so we just need to make sure it's using the latest version of that?

Yes, that's correct @JoelSpeed

JoelSpeed · 2021-07-02T11:17:12Z

/lgtm

lobziik · 2021-07-02T13:20:41Z

/lgtm

soltysh

/lgtm
/approve

openshift-ci · 2021-07-02T13:36:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, JoelSpeed, lobziik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-07-02T13:59:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2020

openshift-ci-robot requested review from deads2k and soltysh September 16, 2020 14:18

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020

Danil-Grigorev force-pushed the default-to-observe-external branch from b0879b4 to cc1f00a Compare September 17, 2020 09:09

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020

Danil-Grigorev force-pushed the default-to-observe-external branch 3 times, most recently from 69598d1 to 94b91f5 Compare September 17, 2020 16:07

Danil-Grigorev changed the title ~~[WIP] Observe external provider by default~~ [WIP] Do not observe external provider by default Sep 22, 2020

Danil-Grigorev mentioned this pull request Sep 22, 2020

Describing steps to support out-of-tree providers openshift/enhancements#463

Merged

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2020

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2020

openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 24, 2021

This was referenced Feb 16, 2021

[OCPCLOUD-1109] External cloud volume plugin observer for KCM openshift/library-go#994

Closed

[OCPCLOUD-1070] Add observe external switch to cloudpovider observer openshift/library-go#895

Merged

Danil-Grigorev force-pushed the default-to-observe-external branch from 94b91f5 to 49ac9ee Compare February 17, 2021 13:54

openshift-ci-robot closed this Apr 14, 2021

openshift-ci bot reopened this Jun 29, 2021

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 29, 2021

Danil-Grigorev changed the title ~~[WIP] Do not observe external provider by default~~ Set --cloud-provider=external for supported platforms Jun 29, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2021

elmiko reviewed Jul 1, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

Danil-Grigorev force-pushed the default-to-observe-external branch from 49ac9ee to 235afdd Compare July 2, 2021 10:56

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2021

openshift-ci bot assigned JoelSpeed Jul 2, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021

Revendor with library-go change for --cloud-provider=external

c5cbdea

Danil-Grigorev force-pushed the default-to-observe-external branch from 235afdd to c5cbdea Compare July 2, 2021 12:32

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021

JoelSpeed mentioned this pull request Jul 2, 2021

[OCPCLOUD-1109] Add ObserveCloudVolumePlugin config observer for KCM config #525

Merged

openshift-ci bot assigned lobziik Jul 2, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021

soltysh approved these changes Jul 2, 2021

View reviewed changes

openshift-ci bot assigned soltysh Jul 2, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021

soltysh mentioned this pull request Jul 2, 2021

Bump openshift/api #542

Merged

Danil-Grigorev changed the title ~~Set --cloud-provider=external for supported platforms~~ [OCPCLOUD-1070] Set --cloud-provider=external for supported platforms Jul 2, 2021

Fedosin mentioned this pull request Jul 2, 2021

Bump github.com/openshift/library-go #544

Closed

openshift-merge-robot merged commit 90927d0 into openshift:master Jul 2, 2021

Conversation

Danil-Grigorev commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 17, 2020

Uh oh!

openshift-ci-robot commented Sep 25, 2020

Uh oh!

openshift-bot commented Dec 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2021

Uh oh!

openshift-ci-robot commented Feb 17, 2021

Uh oh!

openshift-bot commented Apr 14, 2021

Uh oh!

openshift-ci-robot commented Apr 14, 2021

Uh oh!

Danil-Grigorev commented Jun 29, 2021

Uh oh!

Danil-Grigorev commented Jun 29, 2021

Uh oh!

openshift-ci bot commented Jun 29, 2021

Uh oh!

Danil-Grigorev commented Jun 29, 2021

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoelSpeed commented Jul 2, 2021

Uh oh!

Danil-Grigorev commented Jul 2, 2021

Uh oh!

JoelSpeed commented Jul 2, 2021

Uh oh!

lobziik commented Jul 2, 2021

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 2, 2021

Uh oh!

openshift-bot commented Jul 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Danil-Grigorev commented Sep 16, 2020 •

edited

Loading