Skip to content

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Apr 27, 2020

* openshift/api@27622da9: Replace library-go references with build-machinery-go for CRD gen readme
* openshift/api@f5df9218: Builds: Make a bunch of fields omitempty
* openshift/api@0f7ea195: bump to kube v1.18.2
* openshift/api@9e7957d9: bump(build-machinery-go)
* openshift/library-go@e43e3d51: Fix error handling of status controller
* openshift/library-go@a20f1d95: Fix Apply{Deployment,Deployment} to copy input before mutatating
* openshift/library-go@42af5458: Update ApplyDeployment to rely on a hash of the spec
* openshift/library-go@3b4f06f8: Update ApplyDaemonSet to rely on a hash of the spec
* openshift/library-go@c1de486c: Remove bitbucket.org/ww/goautoneg dependency
* openshift/library-go@4960ca0c: Bump to kube v1.18.2
* openshift/library-go@d14c8892: version: make sure to always have namespace when reporting version
* openshift/library-go@556325fc: resourcesynccontroller: fix race in unit test
* openshift/library-go@b3ec7d2d: vendor: Consolidate onto github.com/munnerz/goautoneg
* openshift/library-go@7813cff0: staticpodstate: improve condition and event messages
* openshift/library-go@efe996af: bump(api,build-machinery-go)
* openshift/library-go@029d40b0: Switch go go-bindata/go-bindata for consistency with upstream
* openshift/library-go@53b922b0: make update
* openshift/library-go@e07b1834: Update featuregate unit test to include APIPriorityAndFairness=true
* openshift/library-go@209722f0: events: wire graceful broadcaster shutdown
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 27, 2020

/retest

@mfojtik mfojtik changed the title bump(*): vendor update Bug 1828457: bump(*): vendor update Apr 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 27, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1828457, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 28, 2020

/retest

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 981fb49 into openshift:master Apr 28, 2020
@openshift-ci-robot
Copy link

@mfojtik: All pull requests linked via external trackers have merged: openshift/cluster-authentication-operator#282, openshift/cluster-config-operator#129, openshift/cluster-etcd-operator#323, openshift/cluster-kube-apiserver-operator#837, openshift/cluster-kube-controller-manager-operator#406, openshift/cluster-kube-scheduler-operator#243, openshift/cluster-openshift-apiserver-operator#358, openshift/service-ca-operator#118. Bugzilla bug 1828457 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@mfojtik: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/images 43f1298 link /test images
ci/prow/e2e-aws-operator 43f1298 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 30, 2020

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants