Skip to content

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Apr 27, 2020

* openshift/api@27f27266: Add Route for consoles custom hostname
* openshift/api@1f595939: Add VirtualHostedStyle to S3 configuration options
* openshift/api@366fdb33: Adds WildcardPolicy field to IngressController API
* openshift/api@d363d3fc: Update optional tags where needed
* openshift/api@710ab014: Fix the default for Authentication.ServiceAccountIssuer
* openshift/api@556c4b92: make update
* openshift/api@27622da9: Replace library-go references with build-machinery-go for CRD gen readme
* openshift/api@722c7a62: enable priority and fairness for kube-apiserver
* openshift/api@f5df9218: Builds: Make a bunch of fields omitempty
* openshift/api@6c25f0fd: config/v1/types_infrastructure.go: add service endpoints to aws platform spec and status
* openshift/api@1fc310b2: operator/ingress: Add logging API
* openshift/api@2dadc742: config/v1/types_infrastructure.go: update the cloudConfig spec to define the generated one's location
* openshift/api@b7121e12: config/v1: add status subresource for infrstrastructure
* openshift/api@0f7ea195: bump to kube v1.18.2
* openshift/api@9e7957d9: bump(build-machinery-go)
* openshift/build-machinery-go@8c085b90: Switch to go-bindata/go-bindata for consistency with upstream
* openshift/library-go@e43e3d51: Fix error handling of status controller
* openshift/library-go@c1de486c: Remove bitbucket.org/ww/goautoneg dependency
* openshift/library-go@4960ca0c: Bump to kube v1.18.2
* openshift/library-go@b3ec7d2d: vendor: Consolidate onto github.com/munnerz/goautoneg
* openshift/library-go@7813cff0: staticpodstate: improve condition and event messages
* openshift/library-go@efe996af: bump(api,build-machinery-go)
* openshift/library-go@029d40b0: Switch go go-bindata/go-bindata for consistency with upstream
* openshift/library-go@53b922b0: make update
* openshift/library-go@e07b1834: Update featuregate unit test to include APIPriorityAndFairness=true
* openshift/library-go@209722f0: events: wire graceful broadcaster shutdown
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@openshift-ci-robot
Copy link

@mfojtik: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure 32bb911 link /test e2e-azure
ci/prow/e2e-aws-disruptive 32bb911 link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mfojtik mfojtik changed the title bump(*): vendor update Bug 1828457: bump(*): vendor update Apr 27, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 27, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1828457, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 27, 2020
@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 27, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1828457, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 27, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 27, 2020
@openshift-ci-robot
Copy link

@mfojtik: This pull request references Bugzilla bug 1828457, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 27, 2020
@retroflexer
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cac983f into openshift:master Apr 27, 2020
@openshift-ci-robot
Copy link

@mfojtik: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants