Bug 1809368: bump openshift/api to remove IPv6DualStack feature flag #355

danwinship · 2020-03-02T23:32:05Z

The IPv6DualStack has bugs in 1.17/4.4 even in single-stack clusters so we need to stop setting it.

bump: openshift/api

In particular, to get

openshift/api#585: config: disable IPv6DualStack feature flag

so we don't launch kube-controller-manager with that (still-broken) feature

Also includes:

openshift/api#557: create the IBMCLoudPlatform type for the ingress operator try2
openshift/api#570: Clarify image config doc
openshift/api#569: Enable overriding service account issuer for bound tokens
openshift/api#527: Add kubebuilder annotations to the network types
openshift/api#574: add deprecaction notice for build pipeline strategy
openshift/api#582: config/v1/types_proxy: Clarify trustedCA semantics
openshift/api#583: Clarify FROM behavior in builds
openshift/api#573: Add CRD generator documentation to Readme
openshift/api#576: Remove Description from CLI output to improve its display
openshift/api#589: Add missing enum validations
openshift/api#583: operator/ingress: add dnsrecord type

In particular, to get openshift/api#585: config: disable IPv6DualStack feature flag so we don't launch kube-controller-manager with that (still-broken) feature Also includes: openshift/api#557: create the IBMCLoudPlatform type for the ingress operator try2 openshift/api#570: Clarify image config doc openshift/api#569: Enable overriding service account issuer for bound tokens openshift/api#527: Add kubebuilder annotations to the network types openshift/api#574: add deprecaction notice for build pipeline strategy openshift/api#582: config/v1/types_proxy: Clarify trustedCA semantics openshift/api#583: Clarify FROM behavior in builds openshift/api#573: Add CRD generator documentation to Readme openshift/api#576: Remove Description from CLI output to improve its display openshift/api#589: Add missing enum validations openshift/api#583: operator/ingress: add dnsrecord type

openshift-ci-robot · 2020-03-02T23:32:08Z

@danwinship: This pull request references Bugzilla bug 1809368, which is invalid:

expected Bugzilla bug 1809368 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1809368: bump openshift/api to remove IPv6DualStack feature flag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship · 2020-03-02T23:37:46Z

/bugzilla refresh

openshift-ci-robot · 2020-03-02T23:38:11Z

@danwinship: This pull request references Bugzilla bug 1809368, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1809369 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1809369 targets the "4.5.0" release, matching the expected (4.5.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve
/retest

openshift-bot · 2020-03-03T10:44:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T10:57:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T11:37:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T11:49:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T12:28:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T12:41:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T13:23:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T14:12:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

danwinship · 2020-03-03T14:19:53Z

Repeated e2e-aws failures seem bad...

must-gather logs from one of them show a bunch of:

Mar 03 12:18:18 ip-10-0-8-255 bootkube.sh[12564]: Rendering Kubernetes Controller Manager core manifests...
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: panic: Failed to load "/usr/share/bootkube/manifests/config/bootstrap-config-overrides.yaml": open /usr/share/bootkube/manifests/config/bootstrap-config-overrides.yaml: no such file or directory
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: goroutine 1 [running]:
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: github.com/openshift/cluster-kube-controller-manager-operator/pkg/cmd/render.mustReadTemplateFile(0xc0006be2d0, 0x44, 0x0, 0x0, 0x0, 0x0, 0x0)
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/openshift/cluster-kube-controller-manager-operator@/pkg/cmd/render/render.go:233 +0x1df
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: github.com/openshift/cluster-kube-controller-manager-operator/pkg/cmd/render.(*renderOpts).Run(0xc000369200, 0x0, 0x0)
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/openshift/cluster-kube-controller-manager-operator@/pkg/cmd/render/render.go:209 +0x2d4
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: github.com/openshift/cluster-kube-controller-manager-operator/pkg/cmd/render.NewRenderCommand.func1.1(0xc0007076c0)
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/openshift/cluster-kube-controller-manager-operator@/pkg/cmd/render/render.go:48 +0x4e
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: github.com/openshift/cluster-kube-controller-manager-operator/pkg/cmd/render.NewRenderCommand.func1(0xc0002cd400, 0xc0006c3540, 0x0, 0x5)
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/openshift/cluster-kube-controller-manager-operator@/pkg/cmd/render/render.go:58 +0x11d
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: github.com/spf13/cobra.(*Command).execute(0xc0002cd400, 0xc0006c34f0, 0x5, 0x5, 0xc0002cd400, 0xc0006c34f0)
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/spf13/cobra@v0.0.5/command.go:830 +0x2aa
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: github.com/spf13/cobra.(*Command).ExecuteC(0xc0002ccc80, 0xc000054040, 0xc0002ccc80, 0x6)
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/spf13/cobra@v0.0.5/command.go:914 +0x2fb
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: github.com/spf13/cobra.(*Command).Execute(...)
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/spf13/cobra@v0.0.5/command.go:864
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]: main.main()
Mar 03 12:18:19 ip-10-0-8-255 bootkube.sh[12564]:         github.com/openshift/cluster-kube-controller-manager-operator@/cmd/cluster-kube-controller-manager-operator/main.go:38 +0x18e

openshift-bot · 2020-03-03T15:04:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T15:18:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T16:22:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T23:05:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-03T23:57:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-04T00:36:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-04T01:28:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-04T09:56:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

danwinship · 2020-03-04T13:03:20Z

/hold

openshift-ci-robot · 2020-03-04T13:04:11Z

New changes are detected. LGTM label has been removed.

openshift-ci-robot · 2020-03-04T14:00:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deads2k · 2020-03-04T14:49:29Z

@danwinship this shows a zero diff change.

danwinship · 2020-03-04T15:13:39Z

Yes, I was trying to figure out why every run of e2e-aws on this PR has failed with seemingly-kcm-related bootstrap errors even though there don't seem to be any changes in the bump that should have broken anything. So I reverted everything except the feature gate change and tested again, and it still failed... so I tried reverting that too and testing again, but then hit an infra flake.

danwinship · 2020-03-04T15:13:57Z

/retest

danwinship · 2020-03-04T18:35:49Z

/retest

openshift-ci-robot · 2020-03-04T20:54:04Z

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-upgrade	`1d51a75`	link	`/test e2e-aws-upgrade`
ci/prow/e2e-aws	`1d51a75`	link	`/test e2e-aws`
ci/prow/e2e-aws-operator	`1d51a75`	link	`/test e2e-aws-operator`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh · 2020-03-06T19:38:11Z

Done in #359.

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 2, 2020

openshift-ci-robot requested review from deads2k and sttts March 2, 2020 23:33

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 2, 2020

soltysh approved these changes Mar 3, 2020

View reviewed changes

openshift-ci-robot assigned soltysh Mar 3, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2020

Revert everything except the feature gate change

ba014ea

openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 4, 2020

???

1d51a75

soltysh closed this Mar 6, 2020

danwinship deleted the bump-api branch March 9, 2020 15:42

Bug 1809368: bump openshift/api to remove IPv6DualStack feature flag #355

Bug 1809368: bump openshift/api to remove IPv6DualStack feature flag #355

Uh oh!

Conversation

danwinship commented Mar 2, 2020

Uh oh!

openshift-ci-robot commented Mar 2, 2020

Uh oh!

danwinship commented Mar 2, 2020

Uh oh!

openshift-ci-robot commented Mar 2, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

danwinship commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 3, 2020

Uh oh!

openshift-bot commented Mar 4, 2020

Uh oh!

openshift-bot commented Mar 4, 2020

Uh oh!

openshift-bot commented Mar 4, 2020

Uh oh!

danwinship commented Mar 4, 2020

Uh oh!

openshift-ci-robot commented Mar 4, 2020

Uh oh!

openshift-ci-robot commented Mar 4, 2020

Uh oh!

deads2k commented Mar 4, 2020

Uh oh!

danwinship commented Mar 4, 2020

Uh oh!

danwinship commented Mar 4, 2020

Uh oh!

danwinship commented Mar 4, 2020

Uh oh!

openshift-ci-robot commented Mar 4, 2020

Uh oh!

soltysh commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants