Bug 1769015: Add kubebuilder annotations to the network types #527

abhat · 2019-11-25T19:54:24Z

Add missing annotations and validation markers for network types.

openshift-ci-robot · 2019-11-25T19:54:28Z

@abhat: This pull request references Bugzilla bug 1769015, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1769015: Add kubebuilder annotations to the network types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhat · 2019-11-25T19:54:50Z

/assign @danwinship

network/v1/types.go

soltysh

There are a few elements missing:

You need to copy the crd yamls from network-operator into network/v1 directory, similarly how it's done in operator/v1, for example.
You need to add this rule to Makefile:

$(call add-crd-gen,network,./network/v1,./network/v1,./network/v1)

next to similar lines for operator.

The above 2 steps will ensure we will update the yamls inside this project, and you'll be able to consume it nicely in openshift/cluster-network-operator#398

danwinship

Can you diff the original hand-written CRD against the new generated one to make sure there are no other unexpected changes?

network/v1/types.go

soltysh · 2019-12-16T15:34:00Z

My earlier comments still hold.

abhat · 2020-01-07T19:58:51Z

There are a few elements missing:
1. You need to copy the crd yamls from network-operator into `network/v1` directory, similarly how it's done in `operator/v1`, for example.

2. You need to add this rule to Makefile:
$(call add-crd-gen,network,./network/v1,./network/v1,./network/v1)
next to similar lines for operator.

The above 2 steps will ensure we will update the yamls inside this project, and you'll be able to consume it nicely in openshift/cluster-network-operator#398

For 1, is there a naming scheme convention? Right now the file in the cluster-network-operator repo is called 001-crd.yaml.

I have made the change for calling add-crd-gen

openshift-ci-robot · 2020-01-07T20:11:43Z

@abhat: This pull request references Bugzilla bug 1769015, which is valid.

Details

In response to this:

Bug 1769015: Add kubebuilder annotations to the network types

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhat · 2020-01-07T20:20:49Z

/test verify

network/v1/types.go

network/v1/001-crd.yaml

network/v1/types.go

sttts · 2020-01-10T08:13:11Z

https://github.com/openshift/api/pull/527/files/6d8451fea22ffaed53bea1e362b6da937e41d58a#diff-d22a7c6691ae44dcb021a880f462f6f9 is critical. Otherwise lgtm.

abhat · 2020-01-10T19:19:10Z

@soltysh @sttts can one of you approve and lgtm this?

network/v1/003-netnamespace-crd.yaml

network/v1/types.go

Address review comments Copy the crd yaml into the network directory

knobunc · 2020-01-22T16:09:23Z

@soltysh @sttts is this good to go?

soltysh

/lgtm
/approve

openshift-ci-robot · 2020-01-23T16:11:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

In particular, to get openshift/api#585: config: disable IPv6DualStack feature flag so we don't launch kube-controller-manager with that (still-broken) feature Also includes: openshift/api#557: create the IBMCLoudPlatform type for the ingress operator try2 openshift/api#570: Clarify image config doc openshift/api#569: Enable overriding service account issuer for bound tokens openshift/api#527: Add kubebuilder annotations to the network types openshift/api#574: add deprecaction notice for build pipeline strategy openshift/api#582: config/v1/types_proxy: Clarify trustedCA semantics openshift/api#583: Clarify FROM behavior in builds openshift/api#573: Add CRD generator documentation to Readme openshift/api#576: Remove Description from CLI output to improve its display openshift/api#589: Add missing enum validations openshift/api#583: operator/ingress: add dnsrecord type

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 25, 2019

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2019

openshift-ci-robot assigned danwinship Nov 25, 2019

openshift-ci-robot requested review from danwinship and dcbw November 25, 2019 19:55

abhat force-pushed the annotate_nw_types branch 3 times, most recently from 1b10f56 to 0d43a1c Compare November 25, 2019 20:57

knobunc reviewed Nov 26, 2019

View reviewed changes

network/v1/types.go Outdated Show resolved Hide resolved

soltysh suggested changes Nov 28, 2019

View reviewed changes

danwinship suggested changes Dec 2, 2019

View reviewed changes

network/v1/types.go Show resolved Hide resolved

network/v1/types.go Show resolved Hide resolved

network/v1/types.go Show resolved Hide resolved

sttts reviewed Dec 4, 2019

View reviewed changes

network/v1/types.go Show resolved Hide resolved

abhat mentioned this pull request Dec 12, 2019

Bug 1769015: Bump library go openshift/cluster-network-operator#398

Merged

abhat added 3 commits January 7, 2020 15:10

Bug 1769015: Add kubebuilder annotations to the network types

a63a88e

Update generated files

e205a72

Update swagger docs

3bf8cd9

abhat force-pushed the annotate_nw_types branch from f3e80d5 to 7ce7d4a Compare January 7, 2020 20:11

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2020

abhat changed the base branch from release-4.3 to master January 7, 2020 20:11

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 7, 2020

sttts reviewed Jan 8, 2020

View reviewed changes

network/v1/types.go Outdated Show resolved Hide resolved

sttts reviewed Jan 8, 2020

View reviewed changes

network/v1/types.go Show resolved Hide resolved

sttts reviewed Jan 8, 2020

View reviewed changes

network/v1/types.go Outdated Show resolved Hide resolved

soltysh suggested changes Jan 8, 2020

View reviewed changes

network/v1/001-crd.yaml Outdated Show resolved Hide resolved

network/v1/types.go Show resolved Hide resolved

network/v1/types.go Show resolved Hide resolved

abhat force-pushed the annotate_nw_types branch 2 times, most recently from e43bb9f to 73cd943 Compare January 10, 2020 17:58

soltysh suggested changes Jan 16, 2020

View reviewed changes

network/v1/003-netnamespace-crd.yaml Outdated Show resolved Hide resolved

network/v1/types.go Show resolved Hide resolved

network/v1/types.go Show resolved Hide resolved

Call add-crd-gen in the Makefile

2b89f31

Address review comments Copy the crd yaml into the network directory

abhat force-pushed the annotate_nw_types branch from 73cd943 to 2b89f31 Compare January 16, 2020 15:29

soltysh approved these changes Jan 23, 2020

View reviewed changes

openshift-ci-robot assigned soltysh Jan 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2020

openshift-merge-robot merged commit f263157 into openshift:master Jan 23, 2020

danwinship mentioned this pull request Feb 24, 2020

Bug 1782303: Bump library go openshift/cluster-network-operator#491

Closed

danwinship mentioned this pull request Mar 2, 2020

Bug 1809368: bump openshift/api to remove IPv6DualStack feature flag openshift/cluster-kube-controller-manager-operator#355

Closed

soltysh mentioned this pull request Mar 4, 2020

Bug 1809368: bump openshift/api to remove IPv6DualStack feature flag openshift/cluster-kube-controller-manager-operator#359

Merged

Bug 1769015: Add kubebuilder annotations to the network types #527

Bug 1769015: Add kubebuilder annotations to the network types #527

Uh oh!

Conversation

abhat commented Nov 25, 2019

Uh oh!

openshift-ci-robot commented Nov 25, 2019

Uh oh!

abhat commented Nov 25, 2019

Uh oh!

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

danwinship left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

soltysh commented Dec 16, 2019

Uh oh!

abhat commented Jan 7, 2020

Uh oh!

openshift-ci-robot commented Jan 7, 2020

Uh oh!

abhat commented Jan 7, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sttts commented Jan 10, 2020

Uh oh!

abhat commented Jan 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

knobunc commented Jan 22, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants