Skip to content

Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate #1687

wants to merge 1 commit into from

Conversation

@dinhxuanvu
Copy link
Member

@dinhxuanvu dinhxuanvu commented May 22, 2024

ValidatingAdmissionPolicy is now GA with v1 so it is enabled by default. This DefaultGroupVersionsByFeatureGate for this API is no longer needed.

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented May 22, 2024

Hold until after 1.30 rebase
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2024
@dinhxuanvu dinhxuanvu changed the title Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate API-1783: Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate May 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2024 •
edited by openshift-ci bot
Loading

@dinhxuanvu: This pull request references API-1783 which is a valid jira issue.

In response to this:

ValidatingAdmissionPolicy is now GA with v1 so it is enabled by default. This DefaultGroupVersionsByFeatureGate for this API is no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mfojtik and sanchezl May 22, 2024 13:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented May 25, 2024

/retest-required

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented May 26, 2024 •
edited
Loading

Hold until origin is rebased.
/hold

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Jun 5, 2024

/retest

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Jun 10, 2024

/retest-required

@dinhxuanvu
Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate
6f65a93 
ValidatingAdmissionPolicy is now GA with v1 so it is enabled by default.
This DefaultGroupVersionsByFeatureGate for this API is no longer needed.

Signed-off-by: Vu Dinh <[email protected]>
@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Jun 10, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
soltysh
soltysh approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2024

/retest-required

Remaining retests: 0 against base HEAD 94ca049 and 2 for PR HEAD 6f65a93 in total

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Jun 10, 2024

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2024

/retest-required

Remaining retests: 0 against base HEAD 58d79ab and 1 for PR HEAD 6f65a93 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 14, 2024

/retest-required

Remaining retests: 0 against base HEAD c3adc9e and 0 for PR HEAD 6f65a93 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 14, 2024

/hold

Revision 6f65a93 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

@dinhxuanvu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-single-node-live-iso 6f65a93 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-ovn-single-node 6f65a93 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-operator-single-node 6f65a93 link false /test e2e-gcp-operator-single-node
ci/prow/k8s-e2e-gcp-serial 6f65a93 link false /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-operator-disruptive-single-node 6f65a93 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-upgrade 6f65a93 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-serial 6f65a93 link true /test e2e-aws-ovn-serial
ci/prow/k8s-e2e-gcp 6f65a93 link true /test k8s-e2e-gcp
ci/prow/e2e-gcp-operator 6f65a93 link true /test e2e-gcp-operator
ci/prow/e2e-aws-ovn 6f65a93 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dinhxuanvu dinhxuanvu mentioned this pull request Jun 17, 2024
Merged
@dinhxuanvu dinhxuanvu changed the title API-1783: Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate Remove ValidatingAdmissionPolicy DefaultGroupVersionsByFeatureGate Jun 20, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2024

@dinhxuanvu: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

ValidatingAdmissionPolicy is now GA with v1 so it is enabled by default. This DefaultGroupVersionsByFeatureGate for this API is no longer needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Sep 18, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Sep 18, 2024

No longer needed
/close

@openshift-ci openshift-ci bot closed this Sep 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@dinhxuanvu: Closed this PR.

In response to this:

No longer needed
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@benluddy benluddy mentioned this pull request Mar 26, 2025
Merged
@benluddy benluddy mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sanchezl sanchezl Awaiting requested review from sanchezl

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dinhxuanvu @openshift-ci-robot @openshift-bot @openshift-merge-robot @soltysh