Skip to content

Cover featuregate access errors in PSA configobserver unit tests.#1486

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
benluddy:new-featuregate-unit-tests
Apr 27, 2023
Merged

Cover featuregate access errors in PSA configobserver unit tests.#1486
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
benluddy:new-featuregate-unit-tests

Conversation

@benluddy
Copy link
Copy Markdown
Contributor

@benluddy benluddy commented Apr 26, 2023

Minor follow-up for #1485 (review).

@benluddy
Copy link
Copy Markdown
Contributor Author

benluddy commented Apr 26, 2023

/cc @deads2k

@openshift-ci openshift-ci Bot requested review from deads2k, p0lyn0mial and sttts April 26, 2023 17:16
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@benluddy benluddy force-pushed the new-featuregate-unit-tests branch from 1fb768e to c3260a3 Compare April 26, 2023 17:24
@tkashem
Copy link
Copy Markdown
Contributor

tkashem commented Apr 26, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 26, 2023

@benluddy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node c3260a3 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-ovn-single-node c3260a3 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-disruptive-single-node c3260a3 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 27, 2023
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 27, 2023

on the path to unblocking external azure blocker from coming back in. setting bug

@openshift-merge-robot openshift-merge-robot merged commit 6e29997 into openshift:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sttts sttts Awaiting requested review from sttts

Assignees

@tkashem tkashem

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benluddy @tkashem @deads2k @openshift-merge-robot