switch to featuregates via the API#1485
switch to featuregates via the API#1485openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
the
approved
|
/assign |
| //corruptFeatureSet := &configv1.FeatureGate{ | ||
| // Spec: configv1.FeatureGateSpec{ | ||
| // FeatureGateSelection: configv1.FeatureGateSelection{ | ||
| // FeatureSet: "Bad", | ||
| // CustomNoUpgrade: nil, | ||
| // }, | ||
| // }, | ||
| //} |
There was a problem hiding this comment.
The observer doesn't know about feature sets anymore. Any reason to keep this or the related test cases around and commented?
| }, | ||
| }, | ||
| } | ||
| // TODO provide a hardcoded test harness that allows not-ready and error |
There was a problem hiding this comment.
I see that hardcodedFeatureGateAccess supports this but doesn't export any way to configure it. Are you imagining that it should be made usable for external tests like these? I don't object to dropping a stub implementation right here for use in not ready and error test cases.
|
deads2k
force-pushed
the
new-featuregate
branch
from
ae0d944 to
c0fbca0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deads2k
added
the
bugzilla/valid-bug
|
labelling for the bugs to get this in to enable the external cloud provider unrevert. /retest |
|
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
rendering will need a future update, but I'm working that out with the installer first.