Skip to content

Comments

[WIP] Test e2e-gcp-operator#976

Closed
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:OCPBUGS-13106-e2e-timeouts
Closed

[WIP] Test e2e-gcp-operator#976
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:OCPBUGS-13106-e2e-timeouts

Conversation

@gcs278
Copy link
Contributor

@gcs278 gcs278 commented Sep 13, 2023

WIP to test e2e operator

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 13, 2023
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13106, which is invalid:

  • expected the bug to target the "4.15.0" version, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Standardize the timeouts for waiting for Ingress Controllers to become available in E2E tests. This also updates the provisioning timeout for load-balancer-type Ingress Controllers to be 10 minutes, resolving flakes we sometimes see in GCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 13, 2023
@openshift-ci openshift-ci bot requested review from Miciah and frobware September 13, 2023 21:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278
Copy link
Contributor Author

gcs278 commented Sep 13, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 13, 2023
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13106, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 13, 2023
@openshift-ci openshift-ci bot requested a review from ShudiLi September 13, 2023 21:33
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13106, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

Standardize the timeouts for waiting for Ingress Controllers to become available in E2E tests. This also updates the provisioning timeout for load-balancer-type Ingress Controllers to be 10 minutes, resolving flakes we sometimes see in GCP.

To further illustrate, some E2E authors chose 10 minutes for load-balancer-type service and some chose 5 minutes. My intent is that this update pushes our E2E tests to be more standard to avoid inconsistencies in timeouts, which can lead to wasted investigation time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2023
@gcs278 gcs278 changed the title OCPBUGS-13106: Standardize Ingress Controller provision timeouts in E2E [WIP] OCPBUGS-13106: Standardize Ingress Controller provision timeouts in E2E Sep 22, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2023
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13106, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Standardize the timeouts for waiting for Ingress Controllers to become available in E2E tests. This also updates the provisioning timeout for load-balancer-type Ingress Controllers to be 10 minutes, resolving flakes we sometimes see in GCP.

To further illustrate, some E2E authors chose 10 minutes for load-balancer-type service and some chose 5 minutes. My intent is that this update pushes our E2E tests to be more standard to avoid inconsistencies in timeouts, which can lead to wasted investigation time.

WIP: Waiting for GCP CCM to work so I can compare the two to see if there is a real issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278 gcs278 force-pushed the OCPBUGS-13106-e2e-timeouts branch from 021f3a5 to 3a5d732 Compare October 11, 2023 21:26
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2023
@gcs278 gcs278 changed the title [WIP] OCPBUGS-13106: Standardize Ingress Controller provision timeouts in E2E [WIP] OCPBUGS-13106: Test e2e-gcp-operator Oct 11, 2023
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-13106, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

WIP to test e2e operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 12, 2023

/test e2e-gcp-operator

2 similar comments
@gcs278
Copy link
Contributor Author

gcs278 commented Oct 12, 2023

/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 13, 2023

/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 13, 2023

infrastructure failure
/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 13, 2023

/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 13, 2023

@rfredette
Copy link
Contributor

Borrowing this to check on the health of e2e-gcp-operator again
/test e2e-gcp-operator

@rfredette
Copy link
Contributor

/test e2e-gcp-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 3a5d732 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn 3a5d732 link false /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gcs278 gcs278 changed the title [WIP] OCPBUGS-13106: Test e2e-gcp-operator [WIP] Test e2e-gcp-operator Feb 7, 2024
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 7, 2024
@openshift-ci-robot
Copy link
Contributor

@gcs278: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

WIP to test e2e operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278
Copy link
Contributor Author

gcs278 commented Feb 7, 2024

openshift/cluster-cloud-controller-manager-operator#329 merged so the problem, in theory, should have gone away:
/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Feb 12, 2024

/close

@openshift-ci openshift-ci bot closed this Feb 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@gcs278: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants