OCPBUGS-13106: Increase GCP Concurrent Service Syncs to 10

[JoelSpeed]

This should increase the reactiveness of the GCP service controller, meaning that creation and deletion of load balancers is quicker.

/hold

I would like to review the service controller implementation within GCP and run payload testing before we merge this

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-13106, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This should increase the reactiveness of the GCP service controller, meaning that creation and deletion of load balancers is quicker.

/hold

I would like to review the service controller implementation within GCP and run payload testing before we merge this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/retest

[JoelSpeed]

/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade 10

[openshift-ci]

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d8c5d4f0-c4e6-11ee-8a26-fb48a941f9a3-0

[JoelSpeed]

Given feedback from QE, and looking at the test results here, I think this is safe to proceed with. Will want to monitor GCP in the short term to make sure we don't see any long term issues
/approve
/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elmiko]

this looks ok to me, i think my main concern would be if the cpu usage grows on extremely large clusters. if we want to test more, i wonder if we could try this out in a cluster with say 100 nodes, or maybe run something that creates a lot of services so that we could see if it is getting paused or affects performance.

200m seems like a decent amount of cpu, i'm not sure what we would up the request to.

/lgtm

[openshift-ci]

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@JoelSpeed: Jira Issue OCPBUGS-13106: Some pull requests linked via external trackers have merged:

• openshift/cluster-ingress-operator#924

The following pull requests linked via external trackers have not merged:

• openshift/cluster-ingress-operator#976 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-13106 has not been moved to the MODIFIED state.

Details

In response to this:

This should increase the reactiveness of the GCP service controller, meaning that creation and deletion of load balancers is quicker.

/hold

I would like to review the service controller implementation within GCP and run payload testing before we merge this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gcs278]

/jira refresh

[openshift-ci-robot]

@gcs278: Jira Issue OCPBUGS-13106: All pull requests linked via external trackers have merged:

• openshift/cluster-ingress-operator#924
• openshift/cluster-cloud-controller-manager-operator#329

Jira Issue OCPBUGS-13106 has been moved to the MODIFIED state.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.16.0-202402072112.p0.g0dbe9a4.assembly.stream.el9 for distgit ose-cluster-cloud-controller-manager-operator.
All builds following this will include this PR.

[JoelSpeed]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@JoelSpeed: new pull request created: #359

Details

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.