OCPBUGS-6701: Avoid spurious updates for scope in IngressClass

[gcs278]

Specify spec.parameters.scope on ingressclasses that the operator creates.

Before this commit, the update logic would try to revert the default value that the API set for an ingressclass's scope field.

• pkg/operator/controller/ingressclass/ingressclass.go (desiredIngressClass): Specify spec.parameters.scope with the default value: "Cluster".
• pkg/operator/controller/ingressclass/ingressclass_test.go (Test_desiredIngressClass): Update test to expect spec.parameters.scope to be set.

[openshift-ci-robot]

@gcs278: This pull request references Jira Issue OCPBUGS-6701, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Specify spec.parameters.scope on ingressclasses that the operator creates.

Before this commit, the update logic would try to revert the default value that the API set for an ingressclass's scope field.

• pkg/operator/controller/ingressclass/ingressclass.go (desiredIngressClass): Specify spec.parameters.scope with the default value: "Cluster".
• pkg/operator/controller/ingressclass/ingressclass_test.go (Test_desiredIngressClass): Update test to expect spec.parameters.scope to be set.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gcs278]

/assign @Miciah

[gcs278]

/retest

[Miciah]

Thanks!
/approve
/lgtm
/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e24a381 and 2 for PR HEAD 739e3ed in total

[gcs278]

/retest-required

[openshift-ci]

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	739e3ed	link	false	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gcs278]

/retest-required

[openshift-ci-robot]

@gcs278: All pull requests linked via external trackers have merged:

• openshift/cluster-ingress-operator#879

Jira Issue OCPBUGS-6701 has been moved to the MODIFIED state.

Details

In response to this:

Specify spec.parameters.scope on ingressclasses that the operator creates.

Before this commit, the update logic would try to revert the default value that the API set for an ingressclass's scope field.

• pkg/operator/controller/ingressclass/ingressclass.go (desiredIngressClass): Specify spec.parameters.scope with the default value: "Cluster".
• pkg/operator/controller/ingressclass/ingressclass_test.go (Test_desiredIngressClass): Update test to expect spec.parameters.scope to be set.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[candita]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@candita: new pull request could not be created: failed to create pull request against openshift/cluster-ingress-operator#release-4.13 from head openshift-cherrypick-robot:cherry-pick-879-to-release-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.13 and openshift-cherrypick-robot:cherry-pick-879-to-release-4.13"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[candita]

/cancel cherry-pick

[candita]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@candita: new pull request created: #1056

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.