[release-4.12] OCPBUGS-34110: Avoid spurious updates for scope in IngressClass #1056

openshift-cherrypick-robot · 2024-05-21T23:35:30Z

This is an automated cherry-pick of #879

/assign candita

Specify spec.parameters.scope on ingressclasses that the operator creates. Before this commit, the update logic would try to revert the default value that the API set for an ingressclass's scope field. * pkg/operator/controller/ingressclass/ingressclass.go (desiredIngressClass): Specify spec.parameters.scope with the default value: "Cluster". * pkg/operator/controller/ingressclass/ingressclass_test.go (Test_desiredIngressClass): Update test to expect spec.parameters.scope to be set.

openshift-ci-robot · 2024-05-21T23:35:37Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-6701 has been cloned as Jira Issue OCPBUGS-34110. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-34110: Avoid spurious updates for scope in IngressClass

Details

In response to this:

This is an automated cherry-pick of #879

/assign candita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-21T23:35:52Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34110, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #879

/assign candita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

candita · 2024-05-22T15:40:22Z

/assign @alebedev87

candita · 2024-05-22T15:44:22Z

Seeing a perma issue with machine-config operator:

extension:
master: 2 (ready 2) out of 3 nodes are updating to latest configuration rendered-master-ac5ce5b5939465018ff65c87982274ce

/test e2e-aws-operator

candita · 2024-05-22T19:14:20Z

Root cause of e2e-aws-operator failures seems to be:

util_test.go:727: 2024-05-22 17:10:21 +0000 UTC {kubelet ip-10-0-140-176.ec2.internal} Pod crl-host Failed Failed to pull image "quay.io/centos7/httpd-24-centos7": rpc error: code = Unknown desc = reading manifest latest in quay.io/centos7/httpd-24-centos7: manifest unknown

Need the fix in #1037 to be backported to 4.12.

candita · 2024-05-30T20:27:29Z

#1037 has been backported to 4.12.
/test e2e-aws-operator

alebedev87 · 2024-05-30T20:58:09Z

/lgtm
/approve

openshift-ci · 2024-05-30T20:58:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lihongan · 2024-05-31T04:34:04Z

/label qe-approved

verified by pre-merge test, no "updated IngressClass" in CIO log

$ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.12.0-0.ci.test-2024-05-31-031506-ci-ln-q79x4wk-latest   True        False         35m     Cluster version is 4.12.0-0.ci.test-2024-05-31-031506-ci-ln-q79x4wk-latest

$ oc -n openshift-ingress-operator delete pod ingress-operator-5ddb58b446-cdppn
pod "ingress-operator-5ddb58b446-cdppn" deleted

$ oc -n openshift-ingress-operator logs ingress-operator-5ddb58b446-x9cfv | grep -i "ingressclass"
Defaulted container "ingress-operator" out of: ingress-operator, kube-rbac-proxy
2024-05-31T04:24:19.353Z	INFO	operator.init	controller/controller.go:241	Starting EventSource	{"controller": "ingressclass_controller", "source": "kind source: *v1.IngressController"}
2024-05-31T04:24:19.353Z	INFO	operator.init	controller/controller.go:241	Starting EventSource	{"controller": "ingressclass_controller", "source": "kind source: *v1.IngressClass"}
2024-05-31T04:24:19.353Z	INFO	operator.init	controller/controller.go:241	Starting Controller	{"controller": "ingressclass_controller"}
2024-05-31T04:24:19.859Z	INFO	operator.init	controller/controller.go:241	Starting workers	{"controller": "ingressclass_controller", "worker count": 1}
2024-05-31T04:24:19.859Z	INFO	operator.ingressclass_controller	controller/controller.go:121	reconciling	{"request": "openshift-ingress-operator/default"}

openshift-ci-robot · 2024-05-31T04:34:11Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34110, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-6701 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-6701 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0, 4.13.z
bug has dependents

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

This is an automated cherry-pick of #879

/assign candita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lihongan · 2024-05-31T04:35:12Z

/label cherry-pick-approved

knobunc · 2024-05-31T15:00:37Z

/label backport-risk-assessed

openshift-ci · 2024-05-31T15:00:54Z

@knobunc: Can not set label backport-risk-assessed: Must be member in one of these teams: []

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

candita · 2024-05-31T18:38:39Z

/tide refresh

openshift-ci-robot · 2024-05-31T18:44:23Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34110: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#1056

Jira Issue OCPBUGS-34110 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #879

/assign candita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-05-31T19:22:40Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-05-31T19:36:58Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.12.0-202405311907.p0.g0473ff0.assembly.stream.el8 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

openshift-merge-robot · 2024-06-06T15:53:41Z

Fix included in accepted release 4.12.0-0.nightly-2024-06-06-104737

openshift-cherrypick-robot assigned candita May 21, 2024

openshift-cherrypick-robot mentioned this pull request May 21, 2024

OCPBUGS-6701: Avoid spurious updates for scope in IngressClass #879

Merged

openshift-ci bot changed the title ~~[release-4.12] OCPBUGS-6701: Avoid spurious updates for scope in IngressClass~~ [release-4.12] OCPBUGS-34110: Avoid spurious updates for scope in IngressClass May 21, 2024

openshift-ci bot requested review from knobunc and miheer May 21, 2024 23:35

openshift-ci bot assigned alebedev87 May 22, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 31, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 31, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 31, 2024

openshift-ci bot requested a review from lihongan May 31, 2024 04:34

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 31, 2024

knobunc added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 31, 2024

openshift-ci bot assigned lihongan, melvinjoseph86 and ShudiLi May 31, 2024

openshift-merge-bot bot merged commit 0473ff0 into openshift:release-4.12 May 31, 2024

[release-4.12] OCPBUGS-34110: Avoid spurious updates for scope in IngressClass #1056

[release-4.12] OCPBUGS-34110: Avoid spurious updates for scope in IngressClass #1056

Uh oh!

Conversation

openshift-cherrypick-robot commented May 21, 2024

Uh oh!

openshift-ci-robot commented May 21, 2024

Uh oh!

openshift-ci-robot commented May 21, 2024

Uh oh!

candita commented May 22, 2024

Uh oh!

candita commented May 22, 2024

Uh oh!

candita commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

candita commented May 30, 2024

Uh oh!

alebedev87 commented May 30, 2024

Uh oh!

openshift-ci bot commented May 30, 2024

Uh oh!

lihongan commented May 31, 2024

Uh oh!

openshift-ci-robot commented May 31, 2024

Uh oh!

lihongan commented May 31, 2024

Uh oh!

knobunc commented May 31, 2024

Uh oh!

openshift-ci bot commented May 31, 2024

Uh oh!

candita commented May 31, 2024

Uh oh!

openshift-ci-robot commented May 31, 2024

Uh oh!

openshift-ci bot commented May 31, 2024

Uh oh!

openshift-bot commented May 31, 2024

Uh oh!

openshift-merge-robot commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

candita commented May 22, 2024 •

edited

Loading