OCPBUGS-2429: Fix TestReloadInterval min value test cases and race conditions by gcs278 · Pull Request #842 · openshift/cluster-ingress-operator

gcs278 · 2022-10-14T20:30:28Z

OCPBUGS-2429: Fix TestReloadInterval min value test cases to 1s and fix race condition in which it passes as a false positive by forcing the ingress operator to recreated the router deployment instead of waiting on the ingress operator to report Available.

test/e2e/reloadinterval_test.go: Add deletion of router deployment to trigger reconcile and fix min value test cases

openshift-ci-robot · 2022-10-14T20:30:32Z

@gcs278: This pull request references Jira Issue OCPBUGS-2429, which is invalid:

expected the bug to target the "4.12.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-2429: Fix TestReloadInterval min value test cases to 1s and fix race condition in which it passes as a false positive by forcing the ingress operator to recreated the router deployment instead of waiting on the ingress operator to report Available.

test/e2e/reloadinterval_test.go: Add deletion of router deployment to trigger reconcile and fix min value test cases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2022-10-14T20:34:15Z

/refresh jira

gcs278 · 2022-10-14T20:37:26Z

/jira refresh

openshift-ci-robot · 2022-10-14T20:37:32Z

@gcs278: This pull request references Jira Issue OCPBUGS-2429, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fix race condition in which it passes as a false positive by forcing the ingress operator to recreated the router deployment instead of waiting on the ingress operator to report Available. - test/e2e/reloadinterval_test.go: Add deletion of router deployment to trigger reconcile and fix min value test cases

Miciah · 2022-10-14T21:01:27Z

/approve

openshift-ci · 2022-10-14T21:01:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Miciah · 2022-10-15T01:47:23Z

/retest-required
now that #839 has merged.

miheer · 2022-10-15T03:30:50Z

test/e2e/reloadinterval_test.go

-		{"set reloadInterval 5us", metav1.Duration{Duration: 5 * time.Microsecond}, "5s", true},
-		{"set reloadInterval 500ms", metav1.Duration{Duration: 500 * time.Millisecond}, "5s", true},
+		{"set reloadInterval 200ns", metav1.Duration{Duration: 200 * time.Nanosecond}, "1s", true},
+		{"set reloadInterval 5us", metav1.Duration{Duration: 5 * time.Microsecond}, "1s", true},


does setting to 1s really help ? Won't it cause load on the router ?

Not exactly - it's the value the test is looking for in the router deployment ENV variable. So no load affects, just a comparison value that was wrong.

miheer · 2022-10-15T03:35:16Z

The PR looks lgtm so /lgtm

miheer · 2022-10-15T03:36:02Z

/lgtm

openshift-ci · 2022-10-15T07:19:37Z

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-10-15T07:22:52Z

@gcs278: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#842

Jira Issue OCPBUGS-2429 has been moved to the MODIFIED state.

Details

In response to this:

OCPBUGS-2429: Fix TestReloadInterval min value test cases to 1s and fix race condition in which it passes as a false positive by forcing the ingress operator to recreated the router deployment instead of waiting on the ingress operator to report Available.

test/e2e/reloadinterval_test.go: Add deletion of router deployment to trigger reconcile and fix min value test cases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ShudiLi · 2022-10-26T01:53:22Z

/label qe-approve

openshift-ci · 2022-10-26T01:53:24Z

@ShudiLi: The label(s) /label qe-approve cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label qe-approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ShudiLi · 2022-10-26T01:54:42Z

cancel /label qe-approve

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 14, 2022

openshift-ci bot requested review from Miciah and frobware October 14, 2022 20:31

gcs278 force-pushed the reloadinternval-e2e-fix branch from 52f66f6 to 86372aa Compare October 14, 2022 20:31

gcs278 force-pushed the reloadinternval-e2e-fix branch 3 times, most recently from 645b694 to b983acc Compare October 14, 2022 20:36

openshift-ci bot requested a review from lihongan October 14, 2022 20:37

gcs278 force-pushed the reloadinternval-e2e-fix branch from b983acc to 3ee9c29 Compare October 14, 2022 20:57

gcs278 force-pushed the reloadinternval-e2e-fix branch from 3ee9c29 to 08803d1 Compare October 14, 2022 20:58

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022

gcs278 mentioned this pull request Oct 14, 2022

WIP: TEST COMMIT for logging reloadInterval e2e test #841

Closed

Miciah mentioned this pull request Oct 15, 2022

OCPBUGS-2334: Added nil check for service object on load balancer scope change #839

Merged

miheer reviewed Oct 15, 2022

View reviewed changes

openshift-ci bot assigned miheer Oct 15, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2022

openshift-merge-robot merged commit 68121ce into openshift:master Oct 15, 2022

This was referenced Oct 15, 2022

NE-975: Use ingress config to set default LB type on AWS #837

Merged

NE-1071: Default HAProxy maxconn value to 50000 for OCP 4.12) #836

Merged

Conversation

gcs278 commented Oct 14, 2022

Uh oh!

openshift-ci-robot commented Oct 14, 2022

Uh oh!

gcs278 commented Oct 14, 2022

Uh oh!

gcs278 commented Oct 14, 2022

Uh oh!

openshift-ci-robot commented Oct 14, 2022

Uh oh!

Miciah commented Oct 14, 2022

Uh oh!

openshift-ci bot commented Oct 14, 2022

Uh oh!

Miciah commented Oct 15, 2022

Uh oh!

miheer Oct 15, 2022

Choose a reason for hiding this comment

Uh oh!

gcs278 Oct 17, 2022

Choose a reason for hiding this comment

Uh oh!

miheer commented Oct 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miheer commented Oct 15, 2022

Uh oh!

openshift-ci bot commented Oct 15, 2022

Uh oh!

openshift-ci-robot commented Oct 15, 2022

Uh oh!

ShudiLi commented Oct 26, 2022

Uh oh!

openshift-ci bot commented Oct 26, 2022

Uh oh!

ShudiLi commented Oct 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

miheer commented Oct 15, 2022 •

edited

Loading