Skip to content

WIP: TEST COMMIT for logging reloadInterval e2e test#841

Closed
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:reloadinterval-e2e-fix
Closed

WIP: TEST COMMIT for logging reloadInterval e2e test#841
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:reloadinterval-e2e-fix

Conversation

@gcs278
Copy link
Contributor

@gcs278 gcs278 commented Oct 14, 2022

Testing TestReloadCommit

@gcs278 gcs278 marked this pull request as ready for review October 14, 2022 19:07
@gcs278
Copy link
Contributor Author

gcs278 commented Oct 14, 2022

/hold

@gcs278 gcs278 changed the title TEST COMMIT for logging reloadInterval e2e test WIP: TEST COMMIT for logging reloadInterval e2e test Oct 14, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278 by writing /assign @gcs278 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 14, 2022

I feel confident #842 fixes the problem.

But I can't even get TestReloadInterval to fail because TestScopeChange is failing...
/close

@openshift-ci openshift-ci bot closed this Oct 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2022

@gcs278: Closed this PR.

Details

In response to this:

I feel confident #842 fixes the problem.

But I can't even get TestReloadInterval to fail because TestScopeChange is failing...
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2022

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 7ec8b10 link true /test verify
ci/prow/e2e-aws-operator 7ec8b10 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant