Skip to content

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Sep 8, 2022

Specify a low-privileged security context for the curl pod that the TestCanaryRoute test creates so as not to run afoul of pod security constraints.

  • test/e2e/canary_test.go (buildCanaryCurlPod): Specify a low-privileged security context.

Specify a low-privileged security context for the curl pod that the
TestCanaryRoute test creates so as not to run afoul of pod security
constraints.

This commit fixes OCPBUGS-1049.

https://issues.redhat.com/browse/OCPBUGS-1049

* test/e2e/canary_test.go (buildCanaryCurlPod): Specify a low-privileged
security context.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 8, 2022
@openshift-ci-robot
Copy link
Contributor

@Miciah: This pull request references Jira Issue OCPBUGS-1049, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @quarterpin

Details

In response to this:

Specify a low-privileged security context for the curl pod that the TestCanaryRoute test creates so as not to run afoul of pod security constraints.

  • test/e2e/canary_test.go (buildCanaryCurlPod): Specify a low-privileged security context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 8, 2022
@frobware
Copy link
Contributor

frobware commented Sep 9, 2022

/retest

@frobware
Copy link
Contributor

frobware commented Sep 9, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 14f40c7 and 2 for PR HEAD 2369a82 in total

@Miciah
Copy link
Contributor Author

Miciah commented Sep 9, 2022

The last run of e2e-gcp-ovn-serial failed because the KubeAggregatedAPIDown alert fired.
/test e2e-gcp-ovn-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@Miciah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 2369a82 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-azure-ovn 2369a82 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7977871 into openshift:master Sep 9, 2022
@openshift-ci-robot
Copy link
Contributor

@Miciah: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1049 has been moved to the MODIFIED state.

Details

In response to this:

Specify a low-privileged security context for the curl pod that the TestCanaryRoute test creates so as not to run afoul of pod security constraints.

  • test/e2e/canary_test.go (buildCanaryCurlPod): Specify a low-privileged security context.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants