Skip to content

Add IBM Cloud DNS support for Power VS #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 15, 2022
Merged

Add IBM Cloud DNS support for Power VS #819

openshift-merge-robot merged 1 commit into from
Sep 15, 2022

Conversation

@Karthik-K-N
Copy link
Member

@Karthik-K-N Karthik-K-N commented Aug 24, 2022 •
edited
Loading

Power VS platform uses the IBM Cloud DNS Service. This PR contains the changes to support IBM Cloud DNS Service for Power VS.

Jira Story: https://issues.redhat.com/browse/MULTIARCH-2796

IBM Cloud DNS support has been added throgh the PR: #796

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Aug 24, 2022

/cc @mkumatag @SzucsAti

@openshift-ci openshift-ci bot requested a review from mkumatag August 24, 2022 08:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

@Karthik-K-N: GitHub didn't allow me to request PR reviews from the following users: SzucsAti.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @mkumatag @SzucsAti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SzucsAti
SzucsAti reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@SzucsAti SzucsAti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Aug 25, 2022

@rfredette @lmzuccarelli could you please help in reviewing this

mkumatag
mkumatag suggested changes Aug 29, 2022
View reviewed changes
mkumatag
mkumatag approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@mkumatag
Copy link
Member

mkumatag commented Aug 29, 2022

/assign @frobware

frobware
frobware reviewed Aug 30, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Sep 5, 2022

@frobware could you please take a look and help in merging this PR

frobware
frobware reviewed Sep 5, 2022
View reviewed changes
frobware
frobware reviewed Sep 5, 2022
View reviewed changes
@frobware
Copy link
Contributor

frobware commented Sep 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2022
@frobware
Copy link
Contributor

frobware commented Sep 5, 2022 •
edited
Loading

@openshift/openshift-team-network-edge I took a look over the PR and LGTM. Needs another reviewer to now (review and) approve.

@candita
Copy link
Contributor

candita commented Sep 6, 2022

@frobware - I'll add to the PR Scrub list. Not sure why it didn't start there?

@candita
Copy link
Contributor

candita commented Sep 6, 2022

@Karthik-K-N Please add a JIRA reference and start work on getting the px-approved, qe-approved, docs-approved labels for this PR.

@candita
Copy link
Contributor

candita commented Sep 6, 2022

/retest-required

@mkumatag
Copy link
Member

mkumatag commented Sep 7, 2022

/cc @alishaIBM @juliemathew

for docs and QA

@mkumatag
Copy link
Member

mkumatag commented Sep 7, 2022

/cc @CFields651

for px

@pravin-dsilva
Copy link

pravin-dsilva commented Sep 7, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 7, 2022
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Sep 7, 2022

Jira story related to this PR: https://issues.redhat.com/browse/MULTIARCH-2796

@gcs278
Copy link
Contributor

gcs278 commented Sep 7, 2022

/assign

@candita
Copy link
Contributor

candita commented Sep 7, 2022

/assign @Miciah

Miciah
Miciah reviewed Sep 8, 2022
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@Miciah
Copy link
Contributor

Miciah commented Sep 11, 2022

/approve

#826 should have fixed the issue that caused e2e-aws-operator to fail.
/test e2e-aws-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2022
mkumatag
mkumatag approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2022
@gcs278
Copy link
Contributor

gcs278 commented Sep 11, 2022

I'm late to the party, but had no comments.
/lgtm

@mkumatag
Copy link
Member

mkumatag commented Sep 12, 2022

@sferich888 @CFields651 any help is appreciated!

@CFields651
Copy link

CFields651 commented Sep 12, 2022

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 12, 2022
@mkumatag
Copy link
Member

mkumatag commented Sep 12, 2022

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2022

/retest-required

Remaining retests: 0 against base HEAD 7977871 and 2 for PR HEAD 9fbe971 in total

@mkumatag
Copy link
Member

mkumatag commented Sep 13, 2022

/retest-required

2 similar comments
@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Sep 13, 2022

/retest-required

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Sep 13, 2022

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2022 •
edited
Loading

@Karthik-K-N: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 9fbe971 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mkumatag
Copy link
Member

mkumatag commented Sep 14, 2022

@Miciah the CI jobs are failing forever and they aren't related to the changes we made in this PR, wondering if we can override the job?

@Karthik-K-N
Copy link
Member Author

Karthik-K-N commented Sep 15, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit e65501a into openshift:master Sep 15, 2022
@Karthik-K-N Karthik-K-N deleted the powervs_dns_support branch September 16, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frobware frobware frobware left review comments

@Miciah Miciah Miciah left review comments

@lmzuccarelli lmzuccarelli Awaiting requested review from lmzuccarelli

@rfredette rfredette Awaiting requested review from rfredette

@alishaIBM alishaIBM Awaiting requested review from alishaIBM

@juliemathew juliemathew Awaiting requested review from juliemathew

@sferich888 sferich888 Awaiting requested review from sferich888

+2 more reviewers

@SzucsAti SzucsAti SzucsAti left review comments

@mkumatag mkumatag mkumatag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@frobware frobware

@Miciah Miciah

@gcs278 gcs278

@mkumatag mkumatag

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.