Skip to content

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Dec 8, 2020

This reverts #482.

@openshift-ci-robot
Copy link
Contributor

@Miciah: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Revert "Support changing ingresscontroller load balancer scope"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

/hold
while we discuss.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2020
@sgreene570
Copy link
Contributor

LGTM.
Waiting for input from @knobunc, et al., before we merge this.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

[sig-arch] Managed cluster should have no crashlooping pods in core namespaces over four minutes [Suite:openshift/conformance/parallel]
[sig-instrumentation] Prometheus when installed on the cluster shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured [Early] [Suite:openshift/conformance/parallel]

/test e2e-aws

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

e2e-aws-operator tests passed, but must-gather failed.

/test e2e-aws-operator.

@openshift-ci-robot
Copy link
Contributor

@Miciah: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-azure
  • /test e2e-upgrade
  • /test images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-cluster-ingress-operator-release-4.6-e2e-aws
  • pull-ci-openshift-cluster-ingress-operator-release-4.6-e2e-aws-operator
  • pull-ci-openshift-cluster-ingress-operator-release-4.6-e2e-upgrade
  • pull-ci-openshift-cluster-ingress-operator-release-4.6-images
  • pull-ci-openshift-cluster-ingress-operator-release-4.6-unit
  • pull-ci-openshift-cluster-ingress-operator-release-4.6-verify
Details

In response to this:

e2e-aws-operator tests passed, but must-gather failed.

/test e2e-aws-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

/test e2e-aws-operator

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

/retitle Bug 1905490: Revert "Support changing ingresscontroller load balancer scope"
/hold cancel
We will revert the change in 4.6 with this PR. In a follow-up, we will add logic to block upgrades from 4.6 to 4.7 if the user has modified the service. (Modifications to operator-managed objects are unsupported and should never have been allowed.)

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2020
@openshift-ci-robot openshift-ci-robot changed the title Revert "Support changing ingresscontroller load balancer scope" Bug 1905490: Revert "Support changing ingresscontroller load balancer scope" Dec 8, 2020
@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: Bugzilla bug 1905490 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

e2e-aws-operator tests passed again, and must-gather failed again.
/test e2e-aws-operator

Ach, I was looking at the wrong run.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

Lots of other components' pods are failing to start.

[sig-arch] Managed cluster should have no crashlooping pods in core namespaces over four minutes [Suite:openshift/conformance/parallel]
[sig-instrumentation] Prometheus when installed on the cluster shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured [Early] [Suite:openshift/conformance/parallel]

/test e2e-aws

@sgreene570
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

/bugzilla refresh

1 similar comment
@sgreene570
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: Bugzilla bug 1905490 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@sgreene570: Bugzilla bug 1905490 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

must-gather failed again.
/test e2e-aws-operator

@Miciah
Copy link
Contributor Author

Miciah commented Dec 8, 2020

/test e2e-aws

@Miciah
Copy link
Contributor Author

Miciah commented Dec 9, 2020

Failed again on must-gather.
/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1905490, which is invalid:

  • expected dependent Bugzilla bug 1906560 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knobunc
Copy link

knobunc commented Dec 14, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Miciah,knobunc,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knobunc knobunc added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 14, 2020
@knobunc
Copy link

knobunc commented Dec 14, 2020

Approved based on discussions with @eparis (but he was not somewhere where he could hit the button at the time).

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 14, 2020
@vikaslaad
Copy link

/retest

5 similar comments
@vikaslaad
Copy link

/retest

@vikaslaad
Copy link

/retest

@Miciah
Copy link
Contributor Author

Miciah commented Dec 14, 2020

/retest

@Miciah
Copy link
Contributor Author

Miciah commented Dec 14, 2020

/retest

@Miciah
Copy link
Contributor Author

Miciah commented Dec 14, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 15, 2020

At least the last CI run was able to provision the cluster, but it failed on [sig-arch] Managed cluster should have no crashlooping pods in core namespaces over four minutes because cluster-monitoring-operator's kube-rbac-proxy sidecar container didn't start.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3276bbc into openshift:release-4.6 Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

@Miciah: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1905490 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1905490: Revert "Support changing ingresscontroller load balancer scope"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor Author

Miciah commented Dec 15, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@Miciah: All pull requests linked via external trackers have merged:

Bugzilla bug 1905490 has been moved to the MODIFIED state.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants