add loadBalancerSourceRanges as a preserved field

[matt-simons]

Case 02819675

As an OCP customer
I want to be able to set loadBalancerSourceRanges in the ingress service
so that I can restrict internet ingress to trusted sources

After upgrading from 4.5.x to 4.6.x we found that loadBalancerSourceRanges is no longer preserved when we patch our router-default Service. This regression is blocking our ability to upgrade to 4.6 in production as we can not restrict internet access to our cluster ingress to trusted sources.

This was a previously recommended solution https://access.redhat.com/solutions/5158751

It seems during the refactor release-4.5...openshift:release-4.6 only ClusterIP, ExternalIPs and HealthCheckNodePort were considered as fields that other controllers or users could modify. This PR would add LoadBalancerSourceRanges to that list for the existing use case above.

Would it be possible to accept this PR and backport it to 4.6?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matt-simons
To complete the pull request process, please assign miciah after the PR has been reviewed.
You can assign the PR to them by writing /assign @miciah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Hi @matt-simons. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@matt-simons: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[Miciah]

#507 reverted the change that caused the operator to set loadBalancerSourceRanges, so we can close this PR.
/close

[openshift-ci-robot]

@Miciah: Closed this PR.

Details

In response to this:

#507 reverted the change that caused the operator to set loadBalancerSourceRanges, so we can close this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.