[release-4.6] Bug 1887935: TestForwardedHeaderPolicy*: Make case-insensitive by openshift-cherrypick-robot · Pull Request #475 · openshift/cluster-ingress-operator

openshift-cherrypick-robot · 2020-10-13T15:37:58Z

This is an automated cherry-pick of #474

/assign Miciah

* test/e2e/forwarded_header_policy_test.go (testRouteHeaders): If the polling loop fails, output the client pod's spec and logs as part of the failure message.

Ignore case when comparing the expected response and the actual response in the Forwarded header policy E2E tests. openshift/router#194 turns off HAProxy's HTX option when HTTP/2 is not enabled. As a result, HAProxy does not down-case HTTP header names. * test/e2e/forwarded_header_policy_test.go (testRouteHeaders): Ignore case when comparing the expected response and the actual response.

openshift-ci-robot · 2020-10-13T15:38:09Z

@openshift-cherrypick-robot: Bugzilla bug 1887934 has been cloned as Bugzilla bug 1887935. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1887935: TestForwardedHeaderPolicy*: Make case-insensitive

Details

In response to this:

[release-4.6] Bug 1887934: TestForwardedHeaderPolicy*: Make case-insensitive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-13T15:38:36Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1887935, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1887934 is in the state MODIFIED, which is one of the valid states (MODIFIED, VERIFIED)
dependent Bugzilla bug 1887934 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Details

In response to this:

[release-4.6] Bug 1887935: TestForwardedHeaderPolicy*: Make case-insensitive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2020-10-13T16:23:39Z

/lgtm

openshift-ci-robot · 2020-10-13T16:25:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Miciah · 2020-10-13T17:55:32Z

/hold
Where's tide? This PR probably should not merge before 4.6 is GA.

Miciah · 2020-10-13T17:56:31Z

/refresh

openshift-ci-robot · 2020-10-13T17:56:42Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	`646545c`	link	`/test e2e-aws`
ci/prow/e2e-aws-upgrade	`646545c`	link	`/test e2e-aws-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sgreene570 · 2020-10-15T15:03:04Z

Tide seems to be back on track now.
/retest

Miciah · 2020-10-22T16:06:50Z

/bugzilla refresh
to boost severity.

openshift-ci-robot · 2020-10-22T16:06:56Z

@Miciah: This pull request references Bugzilla bug 1887935, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1887934 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1887934 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Details

In response to this:

/bugzilla refresh
to boost severity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-10-26T05:14:47Z

/hold

frobware · 2020-11-03T18:00:55Z

/hold cancel

openshift-ci-robot · 2020-11-05T03:53:36Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cluster-ingress-operator#475

Bugzilla bug 1887935 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.6] Bug 1887935: TestForwardedHeaderPolicy*: Make case-insensitive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah added 2 commits October 13, 2020 15:37

TestForwardedHeaderPolicy*: Show pod logs if failed

33ba457

* test/e2e/forwarded_header_policy_test.go (testRouteHeaders): If the polling loop fails, output the client pod's spec and logs as part of the failure message.

openshift-cherrypick-robot mentioned this pull request Oct 13, 2020

Bug 1887934: TestForwardedHeaderPolicy*: Make case-insensitive #474

Merged

openshift-ci-robot assigned Miciah Oct 13, 2020

openshift-ci-robot requested review from ironcladlou and knobunc October 13, 2020 15:38

openshift-ci-robot changed the title ~~[release-4.6] Bug 1887934: TestForwardedHeaderPolicy*: Make case-insensitive~~ [release-4.6] Bug 1887935: TestForwardedHeaderPolicy*: Make case-insensitive Oct 13, 2020

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 13, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2020

openshift-ci-robot assigned sgreene570 Oct 13, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020

sgreene570 mentioned this pull request Oct 13, 2020

[release-4.6] Bug 1886213: haproxy-config.template: Only enable HTX for HTTP/2 openshift/router#199

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. labels Oct 22, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 5, 2020

openshift-merge-robot merged commit dd93c33 into openshift:release-4.6 Nov 5, 2020

Conversation

openshift-cherrypick-robot commented Oct 13, 2020

Uh oh!

openshift-ci-robot commented Oct 13, 2020

Uh oh!

openshift-ci-robot commented Oct 13, 2020

Uh oh!

sgreene570 commented Oct 13, 2020

Uh oh!

openshift-ci-robot commented Oct 13, 2020

Uh oh!

Miciah commented Oct 13, 2020

Uh oh!

Miciah commented Oct 13, 2020

Uh oh!

openshift-ci-robot commented Oct 13, 2020

Uh oh!

sgreene570 commented Oct 15, 2020

Uh oh!

Miciah commented Oct 22, 2020

Uh oh!

openshift-ci-robot commented Oct 22, 2020

Uh oh!

Miciah commented Oct 26, 2020

Uh oh!

frobware commented Nov 3, 2020

Uh oh!

openshift-ci-robot commented Nov 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants