Skip to content

[release-4.5] Bug 1878148: Backport: Delete Router Deployment Only Upon DNSRecord Deletion #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Sep 12, 2020
Merged

[release-4.5] Bug 1878148: Backport: Delete Router Deployment Only Upon DNSRecord Deletion #456

openshift-merge-robot merged 3 commits into from
Sep 12, 2020

Conversation

@sgreene570
Copy link
Contributor

@sgreene570 sgreene570 commented Sep 11, 2020

This PR backports #419 to release-4.5. The backport had to be done manually due to merge conflicts. PR #408 was added to this backport to resolve the merge conflicts. #408 introduced a regression, so #412 has been added to this backport as well. All commits were applied as is without hitting any merge conflicts, so reviewing this should be straightforward.

This backport is needed to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1876919.

/assign @danehans @Miciah
/cc @frobware

sgreene570 and others added 3 commits September 11, 2020 09:32
@sgreene570
controller: Make ensure conditions consistent
edce1f4 
Switches all ensure<thing> functions in pkg/operator/controller/ingress
to use a have<thing> boolean rather than manually checking if
<thing> != nil for consistency.
@sgreene570
Fix ensureWildcardDNSRecord & ensureLoadBalancerService
603d2cd 
Add a `wantFoo` boolean to `ensureWildcardDNSRecord` &
`ensureLoadBalancerService` for consistency. Fixes a bug
accidentally introduced in openshift#408.
@danehans @sgreene570
Bug 1850813: Delete Router Deployment Only Upon DNSRecord Deletion
a68ff98
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2020

@sgreene570: This pull request references Bugzilla bug 1878148, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1850813 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1850813 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

[release-4.5] Bug 1878148: Backport: Delete Router Deployment Only Upon DNSRecord Deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link
Contributor

danehans commented Sep 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@sgreene570
Copy link
Contributor Author

sgreene570 commented Sep 11, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2020

@sgreene570: This pull request references Bugzilla bug 1878148, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1850813 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1850813 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 11, 2020
@Miciah
Copy link
Contributor

Miciah commented Sep 11, 2020

e2e-aws-operator failed because the console operator reported that the console route was not ready, the console route was not ready because the console pods' endpoints were unready, and the console pods' endpoints were unready because the console failed to get the auth provider from the API:

2020-09-11T20:02:58Z auth: error contacting auth provider (retrying in 10s): discovery through endpoint https://kubernetes.default.svc/.well-known/oauth-authorization-server failed: 404 Not Found

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/456/pull-ci-openshift-cluster-ingress-operator-release-4.5-e2e-aws-operator/1304497615143964672/artifacts/e2e-aws-operator/pods/openshift-console_console-865b9fd7f8-hp4zd_console.log
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/456/pull-ci-openshift-cluster-ingress-operator-release-4.5-e2e-aws-operator/1304497615143964672/artifacts/e2e-aws-operator/pods/openshift-console_console-865b9fd7f8-hp4zd_console_previous.log
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/456/pull-ci-openshift-cluster-ingress-operator-release-4.5-e2e-aws-operator/1304497615143964672/artifacts/e2e-aws-operator/pods/openshift-console_console-865b9fd7f8-mrdjv_console.log
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/456/pull-ci-openshift-cluster-ingress-operator-release-4.5-e2e-aws-operator/1304497615143964672/artifacts/e2e-aws-operator/pods/openshift-console_console-865b9fd7f8-mrdjv_console_previous.log
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/456/pull-ci-openshift-cluster-ingress-operator-release-4.5-e2e-aws-operator/1304497615143964672/artifacts/e2e-aws-operator/pods/openshift-console_console-866c685b99-hdrjj_console.log
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-ingress-operator/456/pull-ci-openshift-cluster-ingress-operator-release-4.5-e2e-aws-operator/1304497615143964672/artifacts/e2e-aws-operator/pods/openshift-console_console-866c685b99-hdrjj_console_previous.log

/test e2e-aws-operator

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9c9ee8e into openshift:release-4.5 Sep 12, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2020

@sgreene570: All pull requests linked via external trackers have merged:

Bugzilla bug 1878148 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1878148: Backport: Delete Router Deployment Only Upon DNSRecord Deletion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frobware frobware Awaiting requested review from frobware

Assignees

@danehans danehans

@Miciah Miciah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sgreene570 @openshift-ci-robot @danehans @Miciah @openshift-bot @eparis @openshift-merge-robot