Fix ensureWildcardDNSRecord & ensureLoadBalancerService #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miciah
reviewed
Jun 17, 2020
Add a `wantFoo` boolean to `ensureWildcardDNSRecord` & `ensureLoadBalancerService` for consistency. Fixes a bug accidentally introduced in openshift#408.
sgreene570
force-pushed
the
boolean-cleanup-corrections
branch
from
2a6f76d to
c5d6aee
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
wantFooboolean toensureWildcardDNSRecord&ensureLoadBalancerServicefor consistency. Fixes a bugaccidentally introduced in #408.
Also fixes a small comment typo for
desiredWildcardDNSRecord, as well as updates the necessary unit tests.