Delete pod disruption budget logic#376
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Mar 27, 2020
Merged
Delete pod disruption budget logic#376openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
approved
Commit 35d4f4f in 4.2 added logic to create pod disruption budgets. We subsequently decided to remove pod disruption budgets because they caused problems for draining and for small clusters, and so commit f48a2f9 in 4.3 changed the logic to remove any existing pod disruption budget. The logic is consequently unnecessary in 4.4 and later. * manifests/00-cluster-role.yaml: Delete rule to allow the operator to manage the poddisruptionbudgets resource. * pkg/manifests/bindata.go: Regenerate. * pkg/operator/controller/ingress/controller.go (ensureIngressController): Delete call to ensureRouterPodDisruptionBudget. * pkg/operator/controller/ingress/poddisruptionbudget.go: Delete file. (ensureRouterPodDisruptionBudget, desiredRouterPodDisruptionBudget) (currentRouterPodDisruptionBudget, createRouterPodDisruptionBudget) (deleteRouterPodDisruptionBudget, updateRouterPodDisruptionBudget) (podDisruptionBudgetChanged): Delete. * pkg/operator/controller/names.go (RouterPodDisruptionBudgetName): Delete function. * test/e2e/operator_test.go (TestPodDisruptionBudgetDoesNotExist): Delete test.
Miciah
force-pushed
the
delete-pod-disruption-budget-logic
branch
from
3250ef7 to
0241c7b
Compare
ironcladlou
reviewed
Mar 17, 2020
| - poddisruptionbudgets | ||
| verbs: | ||
| - "*" | ||
|
|
Contributor
There was a problem hiding this comment.
Will there be some window where, once this is applied, existing operator process reconciliations could fail to apply the PDB due to RBAC denials? Even if so I'm not sure it matters
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#272 in 4.2 added logic to create pod disruption budgets. We subsequently decided to remove pod disruption budgets because they caused problems for draining and for small clusters, and so #323 in 4.3 changed the logic to remove any existing pod disruption budget. The logic is consequently unnecessary in 4.4 and later.
manifests/00-cluster-role.yaml: Delete rule to allow the operator to manage thepoddisruptionbudgetsresource.pkg/manifests/bindata.go: Regenerate.pkg/operator/controller/ingress/controller.go(ensureIngressController): Delete call toensureRouterPodDisruptionBudget.pkg/operator/controller/ingress/poddisruptionbudget.go: Delete file.(
ensureRouterPodDisruptionBudget,desiredRouterPodDisruptionBudget,currentRouterPodDisruptionBudget,createRouterPodDisruptionBudget,deleteRouterPodDisruptionBudget,updateRouterPodDisruptionBudget,podDisruptionBudgetChanged): Delete.pkg/operator/controller/names.go(RouterPodDisruptionBudgetName): Delete function.test/e2e/operator_test.go(TestPodDisruptionBudgetDoesNotExist): Delete test.