Merged
Conversation
Closed
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Mar 25, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Mar 30, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Mar 30, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 4, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 4, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 4, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 4, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 4, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 4, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 4, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 5, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 8, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 11, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 11, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 11, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 11, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 12, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 12, 2022
… or a route is un-admitted Though the openshift-router is mainly responsible for route object status, the ingress controller plays a small, but significant role in ensuring the route status is accurate. The openshift-router updates the route object's status when it is admitted to an ingress controller. However, the openshift-router is unable to reliably update the route's status when it is un-admitted. Here are the scenarios where the ingress controller steps in: #1 When the ingress controller/router is deleted or killed - The ingress controller knows when a router is deleted because it is the one responsible for deleting it. So it simply calls clearRouteStatus to clear status of routes it is currently admitting. openshift#2 When the ingress controller/router un-admits a route - The ingress controller can determine when a route has been un-admitted based on the fact there is only one real scenario in which that happens: the selectors are update. - When the selectors (routeSelector and namespaceSelector) are updated, it simply clears the status of any route that it is no longer admitting. - We determine what routes are admitted by the current state of the selectors (just like the openshift-router).
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 12, 2022
… or a route is un-admitted
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 12, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 20, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 21, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Apr 26, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
May 3, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
May 4, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
May 4, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
May 4, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
May 4, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
May 6, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
May 9, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Jun 2, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
gcs278
added a commit
to gcs278/cluster-ingress-operator
that referenced
this pull request
Jun 10, 2022
… or a route is not admitted anymore.
This change adds the responsibility of clearing route status to the ingress controller. There are two situations in
which the ingress controller now updates route status:
#1 When the ingress controller/router is deleted or killed
openshift#2 When the ingress controller/router un-admits a route
This also adds a new watch for router pods deleted so that the ingress controller can determine when to clear route
status for #1.
It also adds new status fields for RouteSelector and NamespaceSelector in order to determine when to clear route
status for openshift#2.
alebedev87
added a commit
to alebedev87/cluster-ingress-operator
that referenced
this pull request
Oct 25, 2024
- Reverted changes in TestUnsupportedConfigOverride e2e test. - Added a dedicated unit test for desiredRouterDeployment with DCM: TestDesiredRouterDeploymentDynamicConfigManager. - Reverted the default value of dcmEnabled to false for desiredRouterDeployment in unit tests. - Updated TestUnsupportedConfigOverride e2e test to account for DCM featuregate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.