Skip to content

Bug 1918651: ingress operator doesn't report any error when one of router pods is not ready#677

Closed
brandisher wants to merge 2 commits intoopenshift:masterfrom
brandisher:BZ1918651
Closed

Bug 1918651: ingress operator doesn't report any error when one of router pods is not ready#677
brandisher wants to merge 2 commits intoopenshift:masterfrom
brandisher:BZ1918651

Conversation

@brandisher
Copy link
Contributor

@brandisher brandisher commented Nov 10, 2021

Issue 1: The cluster-ingress-operator reports Available: true and Progressing: false even when the number of defined in ingresscontroller/default.spec.replicas are not all available (e.g. 1/2 replicas available).

Issue 2: The cluster-ingress-operator reports Available: true and Progressing: false even when the ingresscontroller deployment reports Progressing: true.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2021

@brandisher: This pull request references Bugzilla bug 1918651, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1918651: ingress operator doesn't report any error when one of router pods is not ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lihongan November 10, 2021 20:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2021

@brandisher: This pull request references Bugzilla bug 1918651, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1918651: ingress operator doesn't report any error when one of router pods is not ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: brandisher
To complete the pull request process, please assign ironcladlou after the PR has been reviewed.
You can assign the PR to them by writing /assign @ironcladlou in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from Miciah and alebedev87 November 10, 2021 20:52
@brandisher brandisher force-pushed the BZ1918651 branch 2 times, most recently from 2cf6e00 to c0342d1 Compare November 12, 2021 20:06
@brandisher brandisher marked this pull request as ready for review November 12, 2021 21:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2021
@brandisher
Copy link
Contributor Author

/retest

@brandisher brandisher force-pushed the BZ1918651 branch 2 times, most recently from 51050fb to 6ef89c5 Compare November 16, 2021 20:03
Add computeDeploymentProgressingCondition

This function is intended to compute the associated Deployments's
progressing condition.
@candita
Copy link
Contributor

candita commented Nov 17, 2021

/test e2e-aws

This adds a function to search through the IngressControllers to
determine if there are any with a "Progressing" condition. Additionally,
this commit modifies the progressing calculation of the operator to
include the status of the ICs when determining whether or not the
operator is in a Progressing state.
@brandisher
Copy link
Contributor Author

/retest-required

@brandisher
Copy link
Contributor Author

/retest e2e-aws-single-node

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

@brandisher: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-gcp-serial
  • /test e2e-upgrade
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-single-node
  • /test e2e-azure
  • /test e2e-azure-operator
  • /test e2e-gcp-operator

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-single-node
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-serial
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-upgrade
  • pull-ci-openshift-cluster-ingress-operator-master-images
  • pull-ci-openshift-cluster-ingress-operator-master-unit
  • pull-ci-openshift-cluster-ingress-operator-master-verify
Details

In response to this:

/retest e2e-aws-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brandisher
Copy link
Contributor Author

/test e2e-aws-single-node

@brandisher
Copy link
Contributor Author

Rerunning this one more time as there were some registry issues at the time of the last run.

/test e2e-aws-single-node

@brandisher
Copy link
Contributor Author

Random container build failures

/test e2e-aws-single-node

@brandisher
Copy link
Contributor Author

Trying one more time as there's several terraform related errors

/test e2e-aws-single-node

@brandisher brandisher requested a review from frobware November 18, 2021 20:18
@brandisher
Copy link
Contributor Author

Closing this out as this is fixed in OCP 4.9+

@brandisher brandisher closed this Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@brandisher: This pull request references Bugzilla bug 1918651. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1918651: ingress operator doesn't report any error when one of router pods is not ready

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brandisher brandisher deleted the BZ1918651 branch December 3, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants