OCPBUGS-79376: Bump to OSSM 3.3.1 and Istio v1.28.5#1406
OCPBUGS-79376: Bump to OSSM 3.3.1 and Istio v1.28.5#1406openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
Conversation
|
@rhamini3: This pull request references Jira Issue OCPBUGS-79376, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated default versions for Gateway API operator and Istio: in ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test e2e-aws-gatewayapi-conformance |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@hack/gatewayapi-conformance.sh`:
- Line 65: The conformance test invocation hardcodes the OSSM version as
"--version=3.3.0"; update this flag to "--version=3.3.1" in the go test command
(the line containing go test ./conformance ... "--version=3.3.0") so the
reported/tested version matches the PR bump to OSSM 3.3.1.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 767a03e1-6fd2-4960-a141-0128bb8d6ed5
📒 Files selected for processing (4)
cmd/ingress-operator/start.gohack/gatewayapi-conformance.shmanifests/02-deployment-ibm-cloud-managed.yamlmanifests/02-deployment.yaml
|
/test e2e-aws-gatewayapi-conformance |
hack/gatewayapi-conformance.sh
Outdated
|
|
||
| SUPPORTED_FEATURES="BackendTLSPolicy,BackendTLSPolicySANValidation,GRPCRoute,Gateway,GatewayAddressEmpty,GatewayHTTPListenerIsolation,GatewayInfrastructurePropagation,GatewayPort8080,HTTPRoute,HTTPRouteBackendProtocolH2C,HTTPRouteBackendProtocolWebSocket,HTTPRouteBackendRequestHeaderModification,HTTPRouteBackendTimeout,HTTPRouteCORS,HTTPRouteDestinationPortMatching,HTTPRouteHostRewrite,HTTPRouteMethodMatching,HTTPRouteNamedRouteRule,HTTPRouteParentRefPort,HTTPRoutePathRedirect,HTTPRoutePathRewrite,HTTPRoutePortRedirect,HTTPRouteQueryParamMatching,HTTPRouteRequestMirror,HTTPRouteRequestMultipleMirrors,HTTPRouteRequestPercentageMirror,HTTPRouteRequestTimeout,HTTPRouteResponseHeaderModification,HTTPRouteSchemeRedirect,ReferenceGrant" | ||
| SKIPPED_TESTS="HTTPRouteCORSAllowCredentialsBehavior,GatewayStaticAddresses,BackendTLSPolicyConflictResolution" | ||
| SUPPORTED_FEATURES="BackendTLSPolicy,BackendTLSPolicySANValidation,GRPCRoute,Gateway,GatewayAddressEmpty,GatewayHTTPListenerIsolation,GatewayInfrastructurePropagation,GatewayPort8080,HTTPRoute,HTTPRouteBackendProtocolH2C,HTTPRouteBackendProtocolWebSocket,HTTPRouteBackendRequestHeaderModification,HTTPRouteBackendTimeout,HTTPRouteCORS,HTTPRouteDestinationPortMatching,HTTPRouteHostRewrite,HTTPRouteMethodMatching,HTTPRouteNamedRouteRule,HTTPRouteParentRefPort,HTTPRoutePathRedirect,HTTPRoutePathRewrite,HTTPRoutePortRedirect,HTTPRouteQueryParamMatching,HTTPRouteRequestMirror,HTTPRouteRequestMultipleMirrors,HTTPRouteRequestPercentageMirror,HTTPRouteRequestTimeout,HTTPRouteResponseHeaderModification,HTTPRouteSchemeRedirect,ReferenceGrant,BackendTLSPolicyConflictResolution" |
There was a problem hiding this comment.
BackendTLSPolicyConflictResolution may still be broken, but it is worth running at least one test to see the outcome.
|
/lgtm |
|
@rhamini3 Be aware that this will break sail-library, unless you do the sail library 3.3.1 official "bump" here too. If you merge before #1404, sail library will fail because no v1.28.5 helm charts exist. If you merge after #1404, then it will find the v1.28.5 helm charts, however, due to the changes in 28cf0aa, it will pull the upstream istio image because their CSV lacks v1.28.5 istio SHAs. And upstream images don't work right now. The best course of action for keeping noOLM working is to also do the official "bump" or vendoring of the release-3.3.1 branch that has the v1.28.5 SHAs in the CSV. That should happen pretty quickly, as it's just a backport. I'll do my best to keep tabs on the progress of the 3.3.1 CSV update, so you can vendor that here. |
|
The e2e-aws-operator-techpreview failures is what I was expecting per my previous comment. |
|
/test e2e-vsphere-static-metallb-gatewayapi-conformance |
|
/jira refresh |
|
@lihongan: This pull request references Jira Issue OCPBUGS-79376, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@lihongan: This pull request references Jira Issue OCPBUGS-79376, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rhamini3 the PR to update the SHAs is in progress: openshift-service-mesh/sail-operator#765. After that merges (and #1404 merges), we can vendor it. |
|
/test e2e-aws-gatewayapi-conformance |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/test e2e-vsphere-static-metallb-gatewayapi-conformance |
|
/test e2e-aws-gatewayapi-conformance |
hack/gatewayapi-conformance.sh
Outdated
|
|
||
| SUPPORTED_FEATURES="BackendTLSPolicy,BackendTLSPolicySANValidation,GRPCRoute,Gateway,GatewayAddressEmpty,GatewayHTTPListenerIsolation,GatewayInfrastructurePropagation,GatewayPort8080,HTTPRoute,HTTPRouteBackendProtocolH2C,HTTPRouteBackendProtocolWebSocket,HTTPRouteBackendRequestHeaderModification,HTTPRouteBackendTimeout,HTTPRouteCORS,HTTPRouteDestinationPortMatching,HTTPRouteHostRewrite,HTTPRouteMethodMatching,HTTPRouteNamedRouteRule,HTTPRouteParentRefPort,HTTPRoutePathRedirect,HTTPRoutePathRewrite,HTTPRoutePortRedirect,HTTPRouteQueryParamMatching,HTTPRouteRequestMirror,HTTPRouteRequestMultipleMirrors,HTTPRouteRequestPercentageMirror,HTTPRouteRequestTimeout,HTTPRouteResponseHeaderModification,HTTPRouteSchemeRedirect,ReferenceGrant" | ||
| SKIPPED_TESTS="HTTPRouteCORSAllowCredentialsBehavior,GatewayStaticAddresses,BackendTLSPolicyConflictResolution" | ||
| SUPPORTED_FEATURES="BackendTLSPolicy,BackendTLSPolicySANValidation,GRPCRoute,Gateway,GatewayAddressEmpty,GatewayHTTPListenerIsolation,GatewayInfrastructurePropagation,GatewayPort8080,HTTPRoute,HTTPRouteBackendProtocolH2C,HTTPRouteBackendProtocolWebSocket,HTTPRouteBackendRequestHeaderModification,HTTPRouteBackendTimeout,HTTPRouteCORS,HTTPRouteDestinationPortMatching,HTTPRouteHostRewrite,HTTPRouteMethodMatching,HTTPRouteNamedRouteRule,HTTPRouteParentRefPort,HTTPRoutePathRedirect,HTTPRoutePathRewrite,HTTPRoutePortRedirect,HTTPRouteQueryParamMatching,HTTPRouteRequestMirror,HTTPRouteRequestMultipleMirrors,HTTPRouteRequestPercentageMirror,HTTPRouteRequestTimeout,HTTPRouteResponseHeaderModification,HTTPRouteSchemeRedirect,ReferenceGrant,BackendTLSPolicyConflictResolution" |
There was a problem hiding this comment.
@candita @rhamini3 it will be broken because Istio folks decided they will not fix it for now: https://github.com/istio/istio/blob/ba49f7398a8542c3612788e9bd0371c079e44165/tests/integration/pilot/gateway_conformance_test.go#L67
@rhamini3 maybe add this as part of the comment, but I recommend reverting this
|
/test e2e-aws-gatewayapi-conformance |
|
/test e2e-aws-gatewayapi-conformance |
|
/lgtm thanks |
|
/test e2e-azure-operator |
|
Marking as verified since the bump is successful and gatewayAPI objects are created successfully /verified by @mjoseph |
|
@melvinjoseph86: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
confirmed that with NO-OLM approach istio v1.28.5 is used |
|
/test e2e-aws-ovn-hypershift-conformance |
|
/retest-required |
|
@rhamini3: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
dfec6c0
into
openshift:master
|
@rhamini3: Jira Issue Verification Checks: Jira Issue OCPBUGS-79376 Jira Issue OCPBUGS-79376 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.22.0-0.nightly-2026-04-01-151631 |
This PR is bumping OSSM to v3.3.1 and Istio to v1.28.5 to include bug fixes