[WIP] NE-2519: Bump Sail Library to release-3.3.1

[gcs278]

🚧 Note: This is a WIP branch to test with @aslakknutsen's openshift-service-mesh/sail-operator#756. I've drafted the PR/commit to reflect when the sail library merges into 3.3.1 (i'm still using Aslak's dev branch in this build & we don't have SHAs for 3.3.1 yet).

---

Vendor github.com/openshift-service-mesh/sail-operator from release-3.3.1 to obtain Istio 1.28.5 image SHAs from the ClusterServiceVersion. This eliminates floating tags in favor of pinned image digests for GA.

Gateway API downgrade to v1.4.1:
During TP, we used openshift-service-mesh/sail-operator main branch which vendored the latest Istio requiring Gateway API v1.5.0. We decided to pin to v1.4.1 to ensure compatibility with our CRDs.

Now with release-3.3.1 branch, sail-operator vendors Istio 1.28.5 which only requires Gateway API v1.4.0. This allows us to safely remove the pin and downgrade to v1.4.1 without conflicts.

Steps performed:

  Removed gateway-api version pin from go.mod
  go get github.com/openshift-service-mesh/sail-operator@rv3.3.1
  go get sigs.k8s.io/gateway-api@v1.4.1
  go mod tidy
  go mod vendor

[openshift-ci-robot]

@gcs278: This pull request references NE-2519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

🚧 Note: This is a WIP branch to test with @aslakknutsen's openshift-service-mesh/sail-operator#756. I've drafted the PR/commit to reflect when the sail library merges into 3.3.1 (i'm still using Aslak's dev branch in this build & we don't have SHAs for 3.3.1 yet).

---

Vendor github.com/openshift-service-mesh/sail-operator from release-3.3.1 to obtain Istio 1.28.5 image SHAs from the ClusterServiceVersion. This eliminates floating tags in favor of pinned image digests for GA.

Gateway API downgrade to v1.4.1:
During TP, we used openshift-service-mesh/sail-operator main branch which vendored the latest Istio requiring Gateway API v1.5.0. We decided to pin to v1.4.1 to ensure compatibility with our CRDs.

Now with release-3.3.1 branch, sail-operator vendors Istio 1.28.5 which only requires Gateway API v1.4.0. This allows us to safely remove the pin and downgrade to v1.4.1 without conflicts.

Steps performed:

 Removed gateway-api version pin from go.mod
 go get github.com/openshift-service-mesh/sail-operator@rv3.3.1
 go get sigs.k8s.io/gateway-api@v1.4.1
 go mod tidy
 go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c9b8a075-2014-43ff-ba38-963a25a1bcbf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign candita for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gcs278]

I did get a GWAPI failure in e2e-aws-operator, but it seems to be an AWS infra or CCM failure assigning the load balancer:

            message: 'Assigned to service(s) gw-test-f75pf-openshift-default.openshift-ingress.svc.cluster.local:80,
              but failed to assign to all requested addresses: address pending for hostname
              "gw-test-f75pf-openshift-default.openshift-ingress.svc.cluster.local"'

The failure in e2e-azure-operator looks like an unrealted flake.

The failure in e2e-vsphere-static-metallb-operator-gwapi looked like an infra install failure.

/retest

[openshift-ci]

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gcs278]

Closing in favor of #1404
Then likely the real 3.3.1 bump will be in #1406
/close

[openshift-ci]

@gcs278: Closed this PR.

Details

In response to this:

Closing in favor of #1404
Then likely the real 3.3.1 bump will be in #1406
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.