Skip to content

Conversation

@gcs278
Copy link
Contributor

@gcs278 gcs278 commented Apr 26, 2024

Test to see if extending the TestRouteAdmissionPolicy timeout for checking route conditions helps.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@openshift-ci openshift-ci bot requested review from frobware and rfredette April 26, 2024 18:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 26, 2024

cluster install failed
/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 27, 2024

This flake is interesting: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-ingress-operator/1051/pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator/1783933504581537792

route_metrics_test.go:373: failed to update ingresscontroller: Operation cannot be fulfilled on ingresscontrollers.operator.openshift.io "ic-ns-metrics-test": the object has been modified; please apply your changes to the latest version and try again

I don't think this is related to openshift/router#555, but it's something easily fixable.

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 27, 2024

/retest

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 28, 2024

/test e2e-aws-operator
/test e2e-gcp-operator

@gcs278 gcs278 force-pushed the extended-testRouteAdmissionPolicy-test-timeout branch from cfbf2d2 to f7bd311 Compare April 28, 2024 17:08
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2024

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator f7bd311 link true /test e2e-azure-operator
ci/prow/e2e-gcp-operator f7bd311 link true /test e2e-gcp-operator
ci/prow/e2e-aws-operator f7bd311 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gcs278
Copy link
Contributor Author

gcs278 commented May 1, 2024

Extending the timeout isn't a reasonable fix and I'm doing my testing for this flake in #1049
/close

@openshift-ci openshift-ci bot closed this May 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 1, 2024

@gcs278: Closed this PR.

Details

In response to this:

Extending the timeout isn't a reasonable fix and I'm doing my testing for this flake in #1049
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant