Skip to content

WIP DO NOT MERGE: Debug output for TestRouteAdmissionPolicy#1049

Closed
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:TestRouteAdmissionPolicyDebugging
Closed

WIP DO NOT MERGE: Debug output for TestRouteAdmissionPolicy#1049
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:TestRouteAdmissionPolicyDebugging

Conversation

@gcs278
Copy link
Contributor

@gcs278 gcs278 commented Apr 24, 2024

WIP PR to test TestRouteAdmissionPolicy failures. Prints expected vs. got route conditions, enables verbose router logs, and dumps the router logs upon cleanup.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
@openshift-ci openshift-ci bot requested review from Miciah and knobunc April 24, 2024 21:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 25, 2024

/test e2e-aws-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

openshift/router#588 merged. Spinning e2e operator tests to see if we still get flakes in TestRouteAdmissionPolicy
/test e2e-aws-operator
/test e2e-gcp-operator
/test e2e-azure-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

/test e2e-azure-operator

2 similar comments
@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

/test e2e-azure-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

/test e2e-azure-operator

@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

/test e2e-gcp-operator

@gcs278 gcs278 force-pushed the TestRouteAdmissionPolicyDebugging branch from 904e37c to 27104f8 Compare April 30, 2024 22:42
@gcs278
Copy link
Contributor Author

gcs278 commented Apr 30, 2024

Found a flake here, however it was clear my debug code was causing it, because I was rolling the routers by enabling verbose logging and not waiting for the deployment to finish.

Now this should be the real test.

@gcs278
Copy link
Contributor Author

gcs278 commented May 1, 2024

/help

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

openshift/router#587 merged which should fix the flake.
/retest-required

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

Not our flake:
route_metrics_test.go:386: failed to update route: Operation cannot be fulfilled on routes.route.openshift.io "route-rs-foo-label": the object has been modified; please apply your changes to the latest version and try again

/test e2e-aws-operator

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

/test e2e-azure-operator

@gcs278 gcs278 force-pushed the TestRouteAdmissionPolicyDebugging branch from 27104f8 to 55bb3f3 Compare May 2, 2024 18:47
@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

Failure in e2e-azure-operator is NOT a flake. My debug code couldn't find a router pod that disappeared, and used t.Errorf which marked the test as bad. It worked. Fixed the debug code.

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

No flakes.
/retest

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

/test e2e-azure-operator

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

/test e2e-aws-operator

@gcs278
Copy link
Contributor Author

gcs278 commented May 2, 2024

/test e2e-gcp-operator

@gcs278
Copy link
Contributor Author

gcs278 commented May 3, 2024

No flakes.
/test e2e-azure-operator

@gcs278
Copy link
Contributor Author

gcs278 commented May 3, 2024

/test e2e-aws-operator

@gcs278
Copy link
Contributor Author

gcs278 commented May 3, 2024

/test e2e-gcp-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2024

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gcs278
Copy link
Contributor Author

gcs278 commented May 3, 2024

I feel free confident openshift/router#587 fixed the flakes in TestRouteAdmissionPolicy. Closing.
/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2024

@gcs278: Closed this PR.

Details

In response to this:

I feel free confident openshift/router#587 fixed the flakes in TestRouteAdmissionPolicy. Closing.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant