Skip to content

Bug 1769691: Report Available when registry is explicitly Removed#414

Closed
ricardomaraschini wants to merge 2 commits intoopenshift:release-4.1from
ricardomaraschini:removed_conds_rmarasch
Closed

Bug 1769691: Report Available when registry is explicitly Removed#414
ricardomaraschini wants to merge 2 commits intoopenshift:release-4.1from
ricardomaraschini:removed_conds_rmarasch

Conversation

@ricardomaraschini
Copy link
Contributor

This PR was not back ported to release-4.1 and we are not not able to proceed with cluster updates. As I could not cherry-pick directly from the PR(merge conflicts) I am submitting it as a new one.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 11, 2019
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: This pull request references Bugzilla bug 1769691, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1769691: Report Available when registry is explicitly Removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2019
@ricardomaraschini
Copy link
Contributor Author

/assign @dmage @adambkaplan

@dmage
Copy link
Contributor

dmage commented Dec 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 11, 2019
@bparees
Copy link
Contributor

bparees commented Dec 12, 2019

@ricardomaraschini the 4.2 BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1770658) had two PRs associated:
#408
#412

This PR does not seem to include the changes from #408, are they not needed to resolve this?

@ricardomaraschini
Copy link
Contributor Author

@ricardomaraschini the 4.2 BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1770658) had two PRs associated:
#408
#412

This PR does not seem to include the changes from #408, are they not needed to resolve this?

The BZ I refer on this PR does include #408 changes, cherry-picked as #409. This happened because @dmage and me where working on two separated PRs(with overlapping areas) and one of them(this one, originally #387) did not got backported as far as 4.1.

@bparees
Copy link
Contributor

bparees commented Dec 13, 2019

@ricardomaraschini thanks for the explanation, approving

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 13, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Bug 1769691: Report Available when registry is explicitly Removed
@dmage
Copy link
Contributor

dmage commented Dec 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

@ricardomaraschini: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@adambkaplan
Copy link
Contributor

@ricardomaraschini is there a new PR which replaces this one?

@dmage
Copy link
Contributor

dmage commented Jan 7, 2020

This PR was merged: 7d8f4dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants