OCPBUGS-36407: Rename Dockerfile.rhel7 to Dockerfile.ocp#1289
OCPBUGS-36407: Rename Dockerfile.rhel7 to Dockerfile.ocp#1289openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
|
@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Thanks @geliu2016 But looks like openshift/release#53877 needs to merge first for the tests to pass? |
Hi ashwindasr, pre-merge-tested is need to be done before pr merge, code review may ensure this fix before code merge. |
|
/lgtm |
|
/retest-required |
|
@ashwindasr there seems some verification that hardcodes the docker file: |
cd33ec3 to
8c9c298
Compare
|
@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr, geliu2016, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@ashwindasr: Jira Issue OCPBUGS-36407: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-36407 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ashwindasr: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-etcd-operator-container-v4.17.0-202407022311.p0.g9d7b786.assembly.stream.el9 for distgit cluster-etcd-operator. |
Refactor name to
Dockerfile.ocpas a better, version independent, alternative toDockerfile.rhel7since contents are actually rhel9.Please follow up with other changes in this/other repos if necessary. ART has set a fallback for this component in 4.17, hence no other configuration is required from ART's side for 4.17.