Skip to content

Comments

OCPBUGS-36407: Rename Dockerfile.rhel7 to Dockerfile.ocp#1289

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ashwindasr:rename-dockerfile
Jul 2, 2024
Merged

OCPBUGS-36407: Rename Dockerfile.rhel7 to Dockerfile.ocp#1289
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ashwindasr:rename-dockerfile

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 1, 2024

Refactor name to Dockerfile.ocp as a better, version independent, alternative to Dockerfile.rhel7 since contents are actually rhel9.

Please follow up with other changes in this/other repos if necessary. ART has set a fallback for this component in 4.17, hence no other configuration is required from ART's side for 4.17.

@openshift-ci openshift-ci bot requested review from dusk125 and hasbro17 July 1, 2024 20:45
@ashwindasr ashwindasr changed the title OCPBUGS-36407 Rename Dockerfile.rhel7 to Dockerfile.ocp OCPBUGS-36407: Rename Dockerfile.rhel7 to Dockerfile.ocp Jul 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 1, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better version independent alternative to Dockerfile.rhel7 since contents are actually rhel9.

CI PR: openshift/release#53877

Please follow up with other changes in this/other repos if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 July 1, 2024 20:46
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

Details

In response to this:

Refactor name to Dockerfile.ocp as a better version independent alternative to Dockerfile.rhel7 since contents are actually rhel9.

CI PR: openshift/release#53877

Please follow up with other changes in this/other repos if necessary. ART has set a fallback for this component, hence no other configuration is required from ART's side

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@geliu2016 geliu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2024
@ashwindasr
Copy link
Contributor Author

Thanks @geliu2016

But looks like openshift/release#53877 needs to merge first for the tests to pass?

@geliu2016
Copy link

Thanks @geliu2016

But looks like openshift/release#53877 needs to merge first for the tests to pass?

Hi ashwindasr, pre-merge-tested is need to be done before pr merge, code review may ensure this fix before code merge.

@tjungblu
Copy link
Contributor

tjungblu commented Jul 2, 2024

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d82a13d and 2 for PR HEAD cd33ec3 in total

@tjungblu
Copy link
Contributor

tjungblu commented Jul 2, 2024

/retest-required

@tjungblu
Copy link
Contributor

tjungblu commented Jul 2, 2024

@ashwindasr there seems some verification that hardcodes the docker file:
https://github.com/openshift/cluster-etcd-operator/blob/master/Makefile#L34

@ashwindasr ashwindasr force-pushed the rename-dockerfile branch from cd33ec3 to 8c9c298 Compare July 2, 2024 12:32
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
@openshift-ci-robot
Copy link

@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative to Dockerfile.rhel7 since contents are actually rhel9.

Please follow up with other changes in this/other repos if necessary. ART has set a fallback for this component in 4.17, hence no other configuration is required from ART's side for 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from geliu2016 July 2, 2024 12:37
@tjungblu
Copy link
Contributor

tjungblu commented Jul 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, geliu2016, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashwindasr
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 9d7b786 into openshift:master Jul 2, 2024
@openshift-ci-robot
Copy link

@ashwindasr: Jira Issue OCPBUGS-36407: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36407 has been moved to the MODIFIED state.

Details

In response to this:

Refactor name to Dockerfile.ocp as a better, version independent, alternative to Dockerfile.rhel7 since contents are actually rhel9.

Please follow up with other changes in this/other repos if necessary. ART has set a fallback for this component in 4.17, hence no other configuration is required from ART's side for 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2024

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities cd33ec3 link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 8c9c298 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ashwindasr ashwindasr deleted the rename-dockerfile branch July 2, 2024 17:10
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202407022311.p0.g9d7b786.assembly.stream.el9 for distgit cluster-etcd-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants