Skip to content

Comments

add dockerfile_fallback for etcd#5033

Merged
ashwindasr merged 1 commit intoopenshift-eng:openshift-4.17from
ashwindasr:add-fallback-etcd
Jul 1, 2024
Merged

add dockerfile_fallback for etcd#5033
ashwindasr merged 1 commit intoopenshift-eng:openshift-4.17from
ashwindasr:add-fallback-etcd

Conversation

@ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Jul 1, 2024

Follows #5002

Add fallback for etcd

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/cluster-etcd-operator.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/cluster-etcd-operator.yml
Returned error: Additional properties are not allowed ('dockerfile_fallback' was unexpected)

@ashwindasr ashwindasr merged commit 5ad2d3c into openshift-eng:openshift-4.17 Jul 1, 2024
@ashwindasr ashwindasr deleted the add-fallback-etcd branch July 1, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants