Bug 1950270: go.mod: Update openshift/api & go version #265

sgreene570 · 2021-04-20T16:49:03Z

go.mod: Update openshift/api & go version

go.*:

Update openshift/api to commit c22782737ea0a882ed8d4e2c9bd3b974ee3bfca0
to pull in https://github.com/openshift/api#886.
Bump to go version 1.16 in go.mod. Run go mod tidy.
Note that the DNS operator switched to go 1.16 for CI builds in #249.

vendor:

Run go mod vendor.

manifests: Update generated CRD

manifests/0000_70_dns-operator_00-custom-resource-definition.yaml:

Run make update and commit the changes to the DNS operator CRD.

This commit resolves Bug 1950270, in which
oc explain dns.spec.nodePlacement --api-version=operator.openshift.io/v1
displays an outdated default node selector.

openshift-ci-robot · 2021-04-20T16:49:09Z

@sgreene570: This pull request references Bugzilla bug 1950270, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1950270: go.mod: Update openshift/api & go version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-20T16:53:06Z

@sgreene570: This pull request references Bugzilla bug 1950270, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1950270: go.mod: Update openshift/api & go version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-20T17:07:22Z

@sgreene570: This pull request references Bugzilla bug 1950270, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1950270: go.mod: Update openshift/api & go version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sgreene570 · 2021-04-26T15:22:02Z

rebased

sgreene570 · 2021-04-26T20:31:41Z

/hold for openshift/release#18083

go.*: Update openshift/api to commit `c22782737ea0a882ed8d4e2c9bd3b974ee3bfca0` to pull in https://github.com/openshift/api#886. Bump to go version 1.16 in go.mod. Run `go mod tidy`. Note that the DNS operator switched to go 1.16 for CI builds in openshift#249. vendor: Run `go mod vendor`.

manifests/0000_70_dns-operator_00-custom-resource-definition.yaml: Run `make update` and commit the changes to the DNS operator CRD. This commit resolves Bug 1950270, in which `oc explain dns.spec.nodePlacement --api-version=operator.openshift.io/v1` displays an outdated default node selector.

sgreene570 · 2021-04-28T15:08:08Z

rebased
openshift/release#18083 has merged
/unhold

sgreene570 · 2021-04-28T15:20:22Z

Verify job is now passing!
🥳

Miciah · 2021-04-28T15:39:51Z

Update openshift/api to commit c22782737ea0a882ed8d4e2c9bd3b974ee3bfca0
to pull in https://github.com/openshift/api#886.

Link should be openshift/api#886. Otherwise looks good. Thanks!

/lgtm

Miciah · 2021-04-28T15:42:50Z

Thanks!
/lgtm

openshift-ci-robot · 2021-04-28T15:43:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sgreene570 · 2021-04-28T18:34:40Z

/retest

sgreene570 · 2021-04-28T18:43:47Z

/retest

openshift-bot · 2021-04-28T19:35:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T20:47:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T21:00:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-28T23:24:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-04-29T01:24:54Z

@sgreene570: All pull requests linked via external trackers have merged:

Bugzilla bug 1950270 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1950270: go.mod: Update openshift/api & go version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Apr 20, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2021

openshift-ci-robot requested review from ironcladlou, knobunc and lihongan April 20, 2021 16:49

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021

sgreene570 force-pushed the bz-1950270-bump-openshift-api branch from 9a02b96 to 224ca5e Compare April 20, 2021 17:06

sgreene570 force-pushed the bz-1950270-bump-openshift-api branch from 224ca5e to d2b7a47 Compare April 26, 2021 15:21

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021

sgreene570 added 2 commits April 28, 2021 11:07

sgreene570 force-pushed the bz-1950270-bump-openshift-api branch from d2b7a47 to ea147e6 Compare April 28, 2021 15:07

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021

openshift-ci-robot assigned Miciah Apr 28, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021

openshift-ci-robot mentioned this pull request Apr 28, 2021

Bug 1950270: go.mod: Update openshift/api & go version openshift/cluster-ingress-operator#604

Merged

openshift-merge-robot merged commit 3056868 into openshift:master Apr 29, 2021

Bug 1950270: go.mod: Update openshift/api & go version #265

Bug 1950270: go.mod: Update openshift/api & go version #265

Uh oh!

Conversation

sgreene570 commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

openshift-ci-robot commented Apr 20, 2021

Uh oh!

sgreene570 commented Apr 26, 2021

Uh oh!

sgreene570 commented Apr 26, 2021

Uh oh!

sgreene570 commented Apr 28, 2021

Uh oh!

sgreene570 commented Apr 28, 2021

Uh oh!

Miciah commented Apr 28, 2021

Uh oh!

Miciah commented Apr 28, 2021

Uh oh!

openshift-ci-robot commented Apr 28, 2021

Uh oh!

sgreene570 commented Apr 28, 2021

Uh oh!

sgreene570 commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-bot commented Apr 28, 2021

Uh oh!

openshift-ci-robot commented Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sgreene570 commented Apr 20, 2021 •

edited

Loading