[release-4.3] Bug 1859685: Tolerate all taints #186

Miciah · 2020-07-24T17:02:12Z

Configure the operand daemonset to tolerate all taints in order to accommodate user-set taints.

This commit reverts #140.

assets/dns/daemonset.yaml: Tolerate all taints.
pkg/manifests/bindata.go: Regenerate.

This is a manual cherry-pick of #171.

Configure the operand daemonset to tolerate all taints in order to accommodate user-set taints. This commit reverts 3eb10d0. This commit fixes bug 1859685. https://bugzilla.redhat.com/show_bug.cgi?id=1859685 * assets/dns/daemonset.yaml: Tolerate all taints. * pkg/manifests/bindata.go: Regenerate.

openshift-ci-robot · 2020-07-24T17:02:16Z

@Miciah: This pull request references Bugzilla bug 1859685, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "---" instead
expected dependent Bugzilla bug 1847197 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1859685: Tolerate all taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-07-24T17:02:57Z

/bugzilla refresh

openshift-ci-robot · 2020-07-24T17:03:00Z

@Miciah: This pull request references Bugzilla bug 1859685, which is invalid:

expected dependent Bugzilla bug 1847197 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danehans · 2020-07-24T17:05:45Z

/lgtm

openshift-ci-robot · 2020-07-24T17:06:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,danehans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danehans · 2020-07-24T17:10:35Z

/retest

openshift-bot · 2020-07-24T19:24:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-25T01:00:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-25T01:00:17Z

@openshift-bot: This pull request references Bugzilla bug 1859685, which is invalid:

expected dependent Bugzilla bug 1847197 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-26T01:00:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-26T01:00:18Z

@openshift-bot: This pull request references Bugzilla bug 1859685, which is invalid:

expected dependent Bugzilla bug 1847197 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-27T01:00:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-07-27T01:00:23Z

@openshift-bot: This pull request references Bugzilla bug 1859685, which is invalid:

expected dependent Bugzilla bug 1847197 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2020-07-27T02:44:37Z

/bugzilla refresh

openshift-ci-robot · 2020-07-27T02:44:44Z

@lihongan: This pull request references Bugzilla bug 1859685, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1847197 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1847197 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-07T00:49:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-08-07T01:47:31Z

@Miciah: All pull requests linked via external trackers have merged: openshift/cluster-dns-operator#186. Bugzilla bug 1859685 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1859685: Tolerate all taints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 24, 2020

Miciah changed the title ~~Bug 1859685: Tolerate all taints~~ [release-4.3] Bug 1859685: Tolerate all taints Jul 24, 2020

openshift-ci-robot requested review from ironcladlou and knobunc July 24, 2020 17:02

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020

openshift-ci-robot assigned danehans Jul 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 27, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 27, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 6, 2020

openshift-merge-robot merged commit e1b63cc into openshift:release-4.3 Aug 7, 2020

[release-4.3] Bug 1859685: Tolerate all taints #186

[release-4.3] Bug 1859685: Tolerate all taints #186

Uh oh!

Conversation

Miciah commented Jul 24, 2020

Uh oh!

openshift-ci-robot commented Jul 24, 2020

Uh oh!

Miciah commented Jul 24, 2020

Uh oh!

openshift-ci-robot commented Jul 24, 2020

Uh oh!

danehans commented Jul 24, 2020

Uh oh!

openshift-ci-robot commented Jul 24, 2020

Uh oh!

danehans commented Jul 24, 2020

Uh oh!

openshift-bot commented Jul 24, 2020

Uh oh!

openshift-bot commented Jul 25, 2020

Uh oh!

openshift-ci-robot commented Jul 25, 2020

Uh oh!

openshift-bot commented Jul 26, 2020

Uh oh!

openshift-ci-robot commented Jul 26, 2020

Uh oh!

openshift-bot commented Jul 27, 2020

Uh oh!

openshift-ci-robot commented Jul 27, 2020

Uh oh!

lihongan commented Jul 27, 2020

Uh oh!

openshift-ci-robot commented Jul 27, 2020

Uh oh!

openshift-bot commented Aug 7, 2020

Uh oh!

openshift-ci-robot commented Aug 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants