-
Notifications
You must be signed in to change notification settings - Fork 99
Bug 1753059: Don't start DNS on NotReady nodes #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1753059: Don't start DNS on NotReady nodes #140
Conversation
Relax the tolerations for CoreDNS so that it doesn't get started on nodes that aren't yet ready.
|
@ironcladlou: This pull request references Bugzilla bug 1753059, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/uncc @deads2k |
| - operator: Exists | ||
| # DNS needs to run everywhere. | ||
| - key: "node-role.kubernetes.io/master" | ||
| operator: Exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is exactly what we need, but I wanted to start the convo.
|
@Miciah PTAL, tests seem good |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ironcladlou: All pull requests linked via external trackers have merged. Bugzilla bug 1753059 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Relax the tolerations for CoreDNS so that it doesn't get started on
nodes that aren't yet ready.