Skip to content

Comments

SPLAT-1391: promote vSphere from tech preview#272

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
rvanderp3:SPLAT-1391
Jan 31, 2024
Merged

SPLAT-1391: promote vSphere from tech preview#272
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
rvanderp3:SPLAT-1391

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Jan 15, 2024

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2024

@rvanderp3: This pull request references SPLAT-1391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2024
@openshift-ci openshift-ci bot requested review from damdo and elmiko January 15, 2024 20:35
@rvanderp3
Copy link
Contributor Author

/payload ?

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

@rvanderp3: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test crds-sync
  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test fmt
  • /test generate
  • /test images
  • /test lint
  • /test unit
  • /test vendor
  • /test vet

The following commands are available to trigger optional jobs:

  • /test e2e-aws-periodic-pre
  • /test e2e-azure-operator
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-gcp-operator
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-nutanix-ovn
  • /test e2e-openstack-operator
  • /test e2e-openstack-operator-zone
  • /test e2e-vsphere-multi-zone-operator
  • /test e2e-vsphere-operator
  • /test e2e-vsphere-ovn-etcd-scaling

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-crds-sync
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-operator
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-etcd-scaling
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-fmt
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-generate
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-images
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-lint
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-unit
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-vendor
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-vet
Details

In response to this:

/test e2e-vsphere-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-multi-zone-operator
/test e2e-vsphere-operator
/test e2e-vsphere-ovn-etcd-scaling

@rvanderp3
Copy link
Contributor Author

/payload 4.16 nightly informing

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@rvanderp3: trigger 66 job(s) of type informing for the nightly release of OCP 4.16

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-agent-compact-ipv4
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-agent-ha-dualstack
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-agent-sno-ipv6
  • periodic-ci-openshift-release-master-nightly-4.16-console-aws
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.16-periodics-e2e-aws
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-csi
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-fips
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upgrade-rollback-oldest-supported
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-sdn
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-sdn-cgroupsv2
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-sdn-techpreview
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-sdn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-sdn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-upi
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.16-periodics-e2e-azure
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-azure-csi
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-azure-sdn
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-techpreview
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-sdn-upgrade-out-of-change
  • periodic-ci-openshift-release-master-cnv-nightly-4.16-e2e-azure-deploy-cnv
  • periodic-ci-openshift-release-master-cnv-nightly-4.16-e2e-azure-upgrade-cnv
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-driver-toolkit
  • periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.16-periodics-e2e-gcp
  • periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-gcp-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-gcp-ovn-rt
  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-gcp-sdn
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-gcp-sdn-serial
  • periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-sdn-techpreview
  • periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-sdn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-gcp-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-sdn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-serial-virtualmedia-bond
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-bm-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-sdn-bm-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-sdn-serial-ipv4
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-serial-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-serial-ovn-dualstack
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-assisted
  • periodic-ci-openshift-osde2e-main-nightly-4.16-osd-aws
  • periodic-ci-openshift-osde2e-main-nightly-4.16-osd-gcp
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-proxy
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ovn-single-node-live-iso
  • periodic-ci-openshift-osde2e-main-nightly-4.16-rosa-classic-sts
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-telco5g
  • periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-serial
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-upi
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-upi-serial
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-sdn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5b266610-b60c-11ee-861a-203219046933-0

@rvanderp3
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@rvanderp3 rvanderp3 changed the title SPLAT-1391: remove feature gate for vSphere SPLAT-1391: promote vSphere from tech preview Jan 18, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@rvanderp3
Copy link
Contributor Author

/test unit

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2024
@rvanderp3
Copy link
Contributor Author

/test images

go.mod Outdated
Comment on lines 247 to 250
replace (
github.com/openshift/api => github.com/rvanderp3/api v0.0.0-20240118200630-0297f271b04d
github.com/openshift/client-go => github.com/rvanderp3/client-go v0.0.0-20240118202146-7bcaa41f9c0c
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we are waiting on openshift/api#1733 and openshift/client-go#274

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, i'll add a note about that in the description

@damdo
Copy link
Member

damdo commented Jan 19, 2024

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2024

@rvanderp3: This pull request references SPLAT-1391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2024

@rvanderp3: This pull request references SPLAT-1391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi openshift/cluster-config-operator#400

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@rvanderp3: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7a53daf0-b6f6-11ee-82aa-a61215656e9b-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2024

@rvanderp3: This pull request references SPLAT-1391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi openshift/cluster-config-operator#400

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@rvanderp3: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f704b7d0-bbcf-11ee-997e-33d86cf50576-0

@rvanderp3
Copy link
Contributor Author

/test unit

1 similar comment
@rvanderp3
Copy link
Contributor Author

/test unit

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 26, 2024

@rvanderp3: This pull request references SPLAT-1391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rvanderp3
Copy link
Contributor Author

/test unit

@rvanderp3
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024
@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-operator
/test e2e-vsphere-multi-zone-operator

@rvanderp3
Copy link
Contributor Author

/hold

e2e-vsphere-operator and e2e-vsphere-multi-zone-operator tests are timing out. from reviewing the logs, it looks like the operation that is timing out nearly completes. placing a hold to investigate if we can improve the signal here.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024
@rvanderp3
Copy link
Contributor Author

/test unit

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-operator

1 similar comment
@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-operator

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-operator 641469f link false /test e2e-vsphere-operator
ci/prow/e2e-vsphere-multi-zone-operator 641469f link false /test e2e-vsphere-multi-zone-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Jan 31, 2024

/hold cancel

the vsphere operator test is timing out, but it seems to be progressing as expected. I'm going to look at what we can do to improve this in https://issues.redhat.com/browse/SPLAT-1411

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@rvanderp3
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-merge-bot openshift-merge-bot bot merged commit 118df2a into openshift:main Jan 31, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-control-plane-machine-set-operator-container-v4.16.0-202402010042.p0.g118df2a.assembly.stream for distgit ose-cluster-control-plane-machine-set-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants