Skip to content

Comments

SPLAT-1400: promote vSphere control plane machinesets from tech preview#400

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
rvanderp3:SPLAT-1400
Jan 26, 2024
Merged

SPLAT-1400: promote vSphere control plane machinesets from tech preview#400
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
rvanderp3:SPLAT-1400

Conversation

@rvanderp3
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2024

@rvanderp3: This pull request references SPLAT-1400 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rvanderp3 rvanderp3 marked this pull request as ready for review January 25, 2024 16:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2024
@rvanderp3
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot requested review from deads2k and tkashem January 25, 2024 16:57
@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi openshift/cluster-control-plane-machine-set-operator/#272

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@rvanderp3: An error was encountered. No known errors were detected, please see the full error message for details.

Full error message. unable to get additional pr info from string: openshift/cluster-control-plane-machine-set-operator/#272: string: openshift/cluster-control-plane-machine-set-operator/#272 doesn't match expected format: org/repo#number

Please contact an administrator to resolve this issue.

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi openshift/cluster-control-plane-machine-set-operator#272

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@rvanderp3: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/190a0050-bbb3-11ee-9e53-c3ad40249164-0

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-csi openshift/cluster-control-plane-machine-set-operator#272

@vr4manta
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-csi openshift/cluster-control-plane-machine-set-operator#272

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@rvanderp3: trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5cab61e0-bbbe-11ee-93b1-2a6f9e2eb904-0

@rvanderp3
Copy link
Contributor Author

/hold

setting hold while payload tests run

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@rvanderp3: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor Author

payload tests look good

@rvanderp3
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@rvanderp3 rvanderp3 changed the title SPLAT-1400: promote vSphere from tech preview SPLAT-1400: promote vSphere control plane machinesets from tech preview Jan 25, 2024
@rvanderp3
Copy link
Contributor Author

/assign @JoelSpeed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@rvanderp3: This PR was included in a payload test run from openshift/cluster-control-plane-machine-set-operator#272
trigger 1 job(s) for the /payload-(job|aggregate|job-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-vsphere-ovn-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f704b7d0-bbcf-11ee-997e-33d86cf50576-0

@JoelSpeed
Copy link
Contributor

/approve

Merging because this is a useful bump, thanks, but for the future, when dealing with feature gates, it's no longer required to bump this repo. It all lands directly in the payload via o/api now

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, rvanderp3, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 67541b3 into openshift:master Jan 26, 2024
@rvanderp3
Copy link
Contributor Author

/approve

Merging because this is a useful bump, thanks, but for the future, when dealing with feature gates, it's no longer required to bump this repo. It all lands directly in the payload via o/api now

Thanks! I was not aware of that.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-operator-container-v4.16.0-202401272017.p0.g67541b3.assembly.stream for distgit ose-cluster-config-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants