Skip to content

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Nov 30, 2023

Also remove openstack from image replacement as openstack is not in cluster-capi-operator's image-references and does its own release image substitution anyway.

Also remove openstack from image replacement as openstack is not in
cluster-capi-operator's image-references and does its own release image
substitution anyway.
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks matt
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@damdo
Copy link
Member

damdo commented Nov 30, 2023

/retest

@mdbooth mdbooth changed the title openstack: Don't substitute manager container command OCPBUGS-24301: openstack: Don't substitute manager container command Nov 30, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 30, 2023
@openshift-ci-robot
Copy link

@mdbooth: This pull request references Jira Issue OCPBUGS-24301, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Also remove openstack from image replacement as openstack is not in cluster-capi-operator's image-references and does its own release image substitution anyway.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 30, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 30, 2023
@openshift-ci-robot
Copy link

@mdbooth: This pull request references Jira Issue OCPBUGS-24301, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 30, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 03ced4d into openshift:main Nov 30, 2023
@openshift-ci-robot
Copy link

@mdbooth: Jira Issue OCPBUGS-24301: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24301 has been moved to the MODIFIED state.

Details

In response to this:

Also remove openstack from image replacement as openstack is not in cluster-capi-operator's image-references and does its own release image substitution anyway.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-capi-operator-container-v4.15.0-202312010209.p0.g03ced4d.assembly.stream for distgit ose-cluster-capi-operator.
All builds following this will include this PR.

@mdbooth mdbooth deleted the fix-capo-manager-command branch December 1, 2023 09:29
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants