Skip to content

🐛 openshift: Fix label of cluster-capi infrastructure CM #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 30, 2023
Merged

🐛 openshift: Fix label of cluster-capi infrastructure CM #283

openshift-merge-bot merged 1 commit into from
Nov 30, 2023

Conversation

@mdbooth
Copy link

@mdbooth mdbooth commented Nov 30, 2023

Incorrect label prevents deployment by cluster-capi-operator.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@mdbooth mdbooth force-pushed the capo-fix-deployment branch from 6532747 to f9ac32d Compare November 30, 2023 13:25
@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2023

@mdbooth: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mdbooth
Copy link
Author

mdbooth commented Nov 30, 2023

Tested this manually. It now deploys correctly. It doesn't work yet due to openshift/cluster-capi-operator#148

@mdbooth
Copy link
Author

mdbooth commented Nov 30, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023
@EmilienM
Copy link
Member

EmilienM commented Nov 30, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit b6bbfd4 into openshift:main Nov 30, 2023
@EmilienM EmilienM deleted the capo-fix-deployment branch November 30, 2023 16:24
@openshift-bot
Copy link

openshift-bot commented Nov 30, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build openstack-cluster-api-controllers-container-v4.15.0-202311301849.p0.gb6bbfd4.assembly.stream for distgit openstack-cluster-api-controllers.
All builds following this will include this PR.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@gyliu513 @pierreprinetti
Added template for issue and features. (openshift#283)
e11bf1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gryf gryf Awaiting requested review from gryf

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdbooth @EmilienM @openshift-bot