Skip to content

add auth oauth resources to manifests #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 22, 2018
Merged

add auth oauth resources to manifests #7

openshift-merge-robot merged 1 commit into from
Dec 22, 2018

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Dec 21, 2018

This PR adds the authentication and oauth CRDs
@enj is this what you'll need? or no CRs?

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 21, 2018
@enj
Copy link
Contributor

enj commented Dec 21, 2018

I accidentally lost the run level changes when I rebased so you will want to use the 658607f naming format.

Otherwise this is fine for now, we will want to figure out the final resting place for the CRDs and CRs at some point before beta.

@sallyom sallyom force-pushed the add-auth-oauth-resources branch from 1b70c7e to ba3b326 Compare December 21, 2018 18:22
@sallyom sallyom mentioned this pull request Dec 21, 2018
Closed
@sallyom
Copy link
Contributor Author

sallyom commented Dec 21, 2018

@enj updated the naming format (I think it's correct now)

@enj
Copy link
Contributor

enj commented Dec 21, 2018

Looks good, I will tag after #6 merges.

@enj
Copy link
Contributor

enj commented Dec 21, 2018

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2018
@enj
Copy link
Contributor

enj commented Dec 21, 2018

/approve
/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@sallyom
Copy link
Contributor Author

sallyom commented Dec 21, 2018

/retest

enj
enj reviewed Dec 21, 2018
View reviewed changes
manifests/0000_09_cluster-osin-operator_08_auth_cr.yaml Outdated
@@ -0,0 +1,6 @@
apiVersion: v1
items:
Copy link
Contributor

@enj enj Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh just realized this is a list instead of a single item, same with other CR

Copy link
Contributor Author

@sallyom sallyom Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: ) /hold

Copy link
Contributor Author

@sallyom sallyom Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check them out now,all good? (or after shutdown) : )

Copy link
Contributor Author

@sallyom sallyom Dec 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, cluster is much happier now, i guess it wasn't the flaky CI, it was my flakiness, time for a break :)

@sallyom sallyom force-pushed the add-auth-oauth-resources branch from ba3b326 to f83a1ac Compare December 21, 2018 23:23
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2018
@sallyom sallyom force-pushed the add-auth-oauth-resources branch from f83a1ac to fa802bf Compare December 21, 2018 23:26
@sallyom sallyom force-pushed the add-auth-oauth-resources branch from fa802bf to cab71fe Compare December 21, 2018 23:28
@enj
Copy link
Contributor

enj commented Dec 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj
Copy link
Contributor

enj commented Dec 22, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit dab0eab into openshift:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrogers950 mrogers950 Awaiting requested review from mrogers950

@stlaz stlaz Awaiting requested review from stlaz

1 more reviewer

@enj enj enj left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@enj enj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sallyom @enj @openshift-bot @openshift-ci-robot @openshift-merge-robot