Skip to content

Conversation

@enj
Copy link
Contributor

@enj enj commented Dec 20, 2018

@openshift/sig-auth

enj added 6 commits December 20, 2018 15:34
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
Signed-off-by: Monis Khan <[email protected]>
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 20, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2018
@enj
Copy link
Contributor Author

enj commented Dec 20, 2018

/retest

@enj enj removed the request for review from adambkaplan December 20, 2018 20:47
@enj enj force-pushed the enj/f/honor_config branch from ce38c47 to 51acf8a Compare December 20, 2018 21:25
@enj
Copy link
Contributor Author

enj commented Dec 20, 2018

/retest

3 similar comments
@enj
Copy link
Contributor Author

enj commented Dec 21, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Dec 21, 2018

/retest

@enj
Copy link
Contributor Author

enj commented Dec 21, 2018

/retest

@ericavonb
Copy link
Contributor

/hold
for removing some of the extra stuff, e.g. in hack

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2018
@mrogers950
Copy link
Contributor

mrogers950 commented Dec 21, 2018

I think it's a proper start. i'll save the nits for when we start filling everything in.
/lgtm

@mrogers950
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrogers950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enj
Copy link
Contributor Author

enj commented Dec 21, 2018

/hold cancel

Discussed on slack, will worry about clean up after beta.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2018
@openshift-merge-robot openshift-merge-robot merged commit d96a103 into openshift:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants