Skip to content

feat: library-go bump#521

Closed
eggfoobar wants to merge 3 commits intoopenshift:masterfrom
eggfoobar:library_go_bump
Closed

feat: library-go bump#521
eggfoobar wants to merge 3 commits intoopenshift:masterfrom
eggfoobar:library_go_bump

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented Dec 10, 2021 •
edited
Loading

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

Changes:

  • updated library-go to latest

Signed-off-by: ehila ehila@redhat.com

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2021
@openshift-ci openshift-ci Bot requested review from stlaz and sttts December 10, 2021 16:03
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar eggfoobar changed the title [WIP] feat: library-go bump feat: library-go bump Dec 15, 2021
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2021
@jerpeter1
Copy link
Copy Markdown
Member

jerpeter1 commented Dec 16, 2021

/retest-required

@eggfoobar
feat: library-go bump
0581ffb 
updated library-go to latest

Signed-off-by: ehila <ehila@redhat.com>

feat: updated logs lib to explicitly bind flags

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
fix: pull in latest library-go
12f5d03 
pull in to grab fix described here openshift/library-go#1272

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
feat: static resource controller update
a5f0bfe 
latest library-go update allows for finer control of static resource controller, altered call sight to match new method signature

Signed-off-by: ehila <ehila@redhat.com>
@jerpeter1
Copy link
Copy Markdown
Member

jerpeter1 commented Dec 17, 2021

/retest-required

1 similar comment
@jerpeter1
Copy link
Copy Markdown
Member

jerpeter1 commented Dec 17, 2021

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2021

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator a5f0bfe link true /test e2e-operator
ci/prow/e2e-console-login a5f0bfe link true /test e2e-console-login
ci/prow/e2e-agnostic-ipv6 a5f0bfe link false /test e2e-agnostic-ipv6
ci/prow/e2e-aws-single-node a5f0bfe link false /test e2e-aws-single-node
ci/prow/e2e-agnostic a5f0bfe link true /test e2e-agnostic

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stlaz
Copy link
Copy Markdown
Contributor

stlaz commented Dec 20, 2021

/close
the changes described in the first comment already merged in #520

@openshift-ci openshift-ci Bot closed this Dec 20, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2021

@stlaz: Closed this PR.

Details

In response to this:

/close
the changes described in the first comment already merged in #520

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stlaz stlaz Awaiting requested review from stlaz

@sttts sttts Awaiting requested review from sttts

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eggfoobar @jerpeter1 @stlaz