Skip to content

Comments

bug 2039670: Create the PDB dynamically so it does not get created on the SNO topology#514

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
ingvagabund:dynamic-pdb
Jan 12, 2022
Merged

bug 2039670: Create the PDB dynamically so it does not get created on the SNO topology#514
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
ingvagabund:dynamic-pdb

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Nov 26, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2021
@openshift-ci openshift-ci bot requested review from deads2k and stlaz November 26, 2021 19:04
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 27, 2021

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 8, 2021

/retest

@ingvagabund ingvagabund mentioned this pull request Dec 8, 2021
Merged
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 9, 2021

/retest

deads2k
deads2k reviewed Dec 16, 2021
View reviewed changes
pkg/operator/starter.go
},
ShouldDeleteFn: func() bool {
isSno, err := guard.IsSNOCheckFnc(infraLister)()
if err != nil {
Copy link
Contributor

@deads2k deads2k Dec 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have a nicer time if you make the IsSNOCheckFnc only return a bool. I won't quibble though. I bet if you make it, they will come :)

@ingvagabund ingvagabund force-pushed the dynamic-pdb branch 2 times, most recently from 0ced67e to a99980f Compare December 17, 2021 16:18
@ingvagabund
Copy link
Member Author

ingvagabund commented Dec 17, 2021

/retest-required

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2022
@ingvagabund
Copy link
Member Author

ingvagabund commented Jan 10, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2022
@stlaz
Copy link
Contributor

stlaz commented Jan 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@ingvagabund
Copy link
Member Author

ingvagabund commented Jan 10, 2022

/retest-required

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 11, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund ingvagabund changed the title Create the PDB dynamically so it does not get created on the SNO topology bug 2039670: Create the PDB dynamically so it does not get created on the SNO topology Jan 12, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

@ingvagabund: This pull request references Bugzilla bug 2039670, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

bug 2039670: Create the PDB dynamically so it does not get created on the SNO topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 12, 2022
@openshift-ci openshift-ci bot requested a review from zhouying7780 January 12, 2022 08:28
@openshift-merge-robot openshift-merge-robot merged commit 7c16654 into openshift:master Jan 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2022

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 2039670 has been moved to the MODIFIED state.

Details

In response to this:

bug 2039670: Create the PDB dynamically so it does not get created on the SNO topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the dynamic-pdb branch January 12, 2022 08:30
This was referenced Jan 19, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@stlaz stlaz Awaiting requested review from stlaz

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

Assignees

@stlaz stlaz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ingvagabund @stlaz @openshift-bot @deads2k @openshift-merge-robot