bug 2039670: Create the PDB dynamically so it does not get created on the SNO topology#489
Conversation
openshift-ci
bot
added
bugzilla/severity-high
|
@ingvagabund: This pull request references Bugzilla bug 2039670, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/operator/starter.go
Outdated
| statusControllerOptions = append(statusControllerOptions, apiservercontrollerset.WithStatusControllerPdbCompatibleHighInertia("APIServer")) | ||
| } | ||
|
|
||
| infraLister := configInformers.Config().V1().Infrastructures().Lister() |
There was a problem hiding this comment.
Used in guard.IsSNOCheckFnc(infraLister)() on lines 223 and 230
There was a problem hiding this comment.
ah, sorry, it is used on line 223 and 230
There was a problem hiding this comment.
do we have to wait for infraLister to be initialized?
There was a problem hiding this comment.
There was a problem hiding this comment.
Extending the create/delete functions with infraInformer.HasSynced() check.
pkg/operator/starter.go
Outdated
| "v3.11.0/openshift-apiserver/pdb.yaml", | ||
| }, | ||
| ShouldCreateFn: func() bool { | ||
| isSno, err := guard.IsSNOCheckFnc(infraLister)() |
There was a problem hiding this comment.
okay, so it will conditionally create the pdb.yaml based on the current plantform
There was a problem hiding this comment.
Yes. Right now it is only SNO. In the future the condition might be more complex.
| }, | ||
| ShouldCreateFn: func() bool { | ||
| isSno, err := guard.IsSNOCheckFnc(infraLister)() | ||
| if err != nil { |
There was a problem hiding this comment.
would it make sense to log the error?
ingvagabund
force-pushed
the
dynamic-pdb
branch
from
e22f978 to
144c6b9
Compare
ingvagabund
force-pushed
the
dynamic-pdb
branch
2 times, most recently
from
1da5c40 to
0838322
Compare
ingvagabund
force-pushed
the
dynamic-pdb
branch
from
0838322 to
d2ba31f
Compare
openshift-ci
bot
added
the
needs-rebase
ingvagabund
force-pushed
the
dynamic-pdb
branch
from
d2ba31f to
ba14267
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@ingvagabund: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@ingvagabund: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2039670 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Builds on top of openshift/library-go#1246 and WithIsSNOCheck from openshift/library-go#1238.