Skip to content

Consolidate open changes #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
enj merged 4 commits into from
Jan 24, 2019
Merged

Consolidate open changes #34

enj merged 4 commits into from
Jan 24, 2019

Conversation

@enj
Copy link
Contributor

@enj enj commented Jan 21, 2019

All of these changes are required for beta2.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2019
This was referenced Jan 21, 2019
Closed
Closed
Closed
@enj enj removed the request for review from smarterclayton January 21, 2019 14:42
@enj
Copy link
Contributor Author

enj commented Jan 21, 2019

Tagging so bot will keep retesting. All of the individual PRs have been tagged earlier.

@enj enj added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@stlaz
Copy link
Contributor

stlaz commented Jan 22, 2019

/retest
rolls the dice, hopes for 20

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Jan 22, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Jan 23, 2019

/retest

This was referenced Jan 23, 2019
Merged
Closed
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@stlaz
Copy link
Contributor

stlaz commented Jan 23, 2019

/retest
/meowvie

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2019

@stlaz: cat image

Details

In response to this:

/retest
/meowvie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Contributor

stlaz commented Jan 23, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@droslean
Copy link
Member

droslean commented Jan 23, 2019

/test e2e-aws

@droslean
Copy link
Member

droslean commented Jan 23, 2019

/test e2e-aws-operator

sallyom and others added 4 commits January 23, 2019 09:11
@sallyom @enj
replace cluster-osin-operator/cluster-authentication-operator
d419108
@sallyom @enj
rename imports cluster-osin to cluster-authentication
b27cb39
@enj
Try to fix issues caused by rename
dd1d604 
Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj
Add log level support
3053e79 
This allows configuring the log level of the integrated OAuth server
via the operator config.

We now track the operator config's resource version in the
deployment hash.  This along with including the hash in the
deployment's metadata guarantees that we rollout correctly when the
operator's config changes.

We still do not rollout in all cases due to the resource syncer.
Once we correctly track those config maps and secrets, we should be
good.

We may end up rolling out "too often," but we can target the hash
more closely in the future if that happens.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@enj enj force-pushed the enj/i/deployment_log_new branch from f19707d to 3053e79 Compare January 23, 2019 14:11
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2019

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2019
@enj enj added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

mrogers950
mrogers950 approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@mrogers950 mrogers950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrogers950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@stlaz
Copy link
Contributor

stlaz commented Jan 24, 2019

/retest

1 similar comment
@stlaz
Copy link
Contributor

stlaz commented Jan 24, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@enj
Copy link
Contributor Author

enj commented Jan 24, 2019

These changes work fine locally. Let's see if we get any better information by merging and letting CI build new images based on the new manifests. Will revert if needed.

YOLO

@enj enj merged commit d22a597 into openshift:master Jan 24, 2019
@stlaz stlaz mentioned this pull request Jan 24, 2019
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2019

@enj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 3053e79 link /test e2e-aws
ci/prow/e2e-aws-operator 3053e79 link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrogers950 mrogers950 mrogers950 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrogers950 mrogers950

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@enj @openshift-bot @stlaz @openshift-ci-robot @droslean @mrogers950 @sallyom