-
Notifications
You must be signed in to change notification settings - Fork 25
OCPBUGS-33170: All containers must fallback to logs on error #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33170: All containers must fallback to logs on error #207
Conversation
|
@damdo: This pull request references Jira Issue OCPBUGS-33170, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Assuming template generation is based on the upstream templates, we should pick this up automatically if kubernetes-sigs#10580 merges. |
|
/test e2e-hypershift |
|
/lgtm |
|
/jira refresh |
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-33170, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@damdo: Jira Issue OCPBUGS-33170: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-33170 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-api-container-v4.16.0-202405100946.p0.g5830a10.assembly.stream.el9 for distgit ose-cluster-api. |
In 4.17, we are enforcing this value for all OpenShift containers via tests, link in bug comment. This helps with debugging to ensure we have logs available.
Ref: openshift/cluster-capi-operator#172