Skip to content

OCPBUGS-33170: Container fallback to logs on error#224

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
damdo:container-fall-back-to-log
May 7, 2024
Merged

OCPBUGS-33170: Container fallback to logs on error#224
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
damdo:container-fall-back-to-log

Conversation

@damdo
Copy link
Member

@damdo damdo commented May 3, 2024

In 4.17, we are enforcing this value for all OpenShift containers via tests, link in bug comment. This helps with debugging to ensure we have logs available.

Ref: openshift/cluster-capi-operator#172

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 3, 2024
@openshift-ci-robot
Copy link
Contributor

@damdo: This pull request references Jira Issue OCPBUGS-33170, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In 4.17, we are enforcing this value for all OpenShift containers via tests, link in bug comment. This helps with debugging to ensure we have logs available.

Ref: openshift/cluster-capi-operator#172

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JoelSpeed and racheljpg May 3, 2024 13:17
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c2f91b5 and 2 for PR HEAD f00a90c in total

@damdo
Copy link
Member Author

damdo commented May 4, 2024

/retest-required

@damdo
Copy link
Member Author

damdo commented May 4, 2024

/retest

@damdo
Copy link
Member Author

damdo commented May 7, 2024

/test ci/prow/e2e-gcp-serial

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@damdo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-gcp
  • /test e2e-gcp-capi-techpreview
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-serial
  • /test images
  • /test unit

The following commands are available to trigger optional jobs:

  • /test okd-scos-images
  • /test verify-commits

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-api-provider-gcp-master-e2e-gcp
  • pull-ci-openshift-cluster-api-provider-gcp-master-e2e-gcp-capi-techpreview
  • pull-ci-openshift-cluster-api-provider-gcp-master-e2e-gcp-ovn-techpreview
  • pull-ci-openshift-cluster-api-provider-gcp-master-e2e-gcp-serial
  • pull-ci-openshift-cluster-api-provider-gcp-master-images
  • pull-ci-openshift-cluster-api-provider-gcp-master-unit
  • pull-ci-openshift-cluster-api-provider-gcp-master-verify-commits
Details

In response to this:

/test ci/prow/e2e-gcp-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-gcp-serial

The job is running the default featureset, which does not yet include anything from this repository. Looking at the failure, it appears to be a networking (OVN) related issue and nothing to do with this change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-gcp-serial

Details

In response to this:

/override ci/prow/e2e-gcp-serial

The job is running the default featureset, which does not yet include anything from this repository. Looking at the failure, it appears to be a networking (OVN) related issue and nothing to do with this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 02432df into openshift:master May 7, 2024
@openshift-ci-robot
Copy link
Contributor

@damdo: Jira Issue OCPBUGS-33170: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33170 has not been moved to the MODIFIED state.

Details

In response to this:

In 4.17, we are enforcing this value for all OpenShift containers via tests, link in bug comment. This helps with debugging to ensure we have logs available.

Ref: openshift/cluster-capi-operator#172

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-gcp-cluster-api-controllers-container-v4.17.0-202405071820.p0.g02432df.assembly.stream.el9 for distgit ose-gcp-cluster-api-controllers.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments