Start work on equinix metal provider by detiber · Pull Request #1 · openshift/cluster-api-provider-equinix-metal

detiber · 2020-10-12T19:48:48Z

Basic bare functionality in place.

detiber · 2020-10-12T19:49:06Z

/cc @displague

openshift-ci-robot · 2020-10-12T19:49:07Z

@detiber: GitHub didn't allow me to request PR reviews from the following users: displague.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @displague

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2020-11-19T10:59:59Z

Was this provider implementation based off of another? I notice a lot of the boilerplate stuff seems to be familiar, just wondering if I could diff with the other implementation to review any changes/diffs in the boilerplate

detiber · 2020-11-24T21:21:36Z

@JoelSpeed It's kind of an amalgamation of openshift/cluster-api-provider-gcp openshift/cluster-api-provider-aws and some bits taken from kubernetes-sigs/cluster-api-provider-packet circa v1alpha1. It wasn't overly clear if there were preferred patterns or scaffolding for openshift machine api providers. I'd be happy to refactor based on top of a particular provider if you feel it would be more aligned with best practices, though.

JoelSpeed · 2020-11-25T11:33:24Z

No worries, I was just thinking if it's close to a previous provider I might be able to do a diff to reduce the review load. Eg compare the boilerplate/structure and make sure it looks correct and in keeping with prior art.

I have been rushed this week so haven't had an opportunity to look into it yet, but will try to do so soon, sorry for the delay.

elmiko · 2021-01-12T21:29:25Z

hey @detiber and @displague , i'm just starting to review this and i was going through the basics of building and reviewing the base artifacts. but when i run the make build i am seeing the following error:

$ make build
docker run --rm -e CGO_ENABLED=1 -v "/home/mike/src/cluster-api-provider-equinix-metal":/go/src/github.com/openshift/cluster-api-provider-equinix-metal:Z -w /go/src/openshift/cluster-api-provider-equinix-metal openshift/origin-release:golang-1.13 go build  -o "bin/machine-controller-manager" \
               -ldflags "-X github.com/openshift/cluster-api-provider-equinix-metal/pkg/version.Raw=20f599b -extldflags -static" "github.com/openshift/cluster-api-provider-equinix-metal/cmd/manager"
Error: chdir: No such file or directory: OCI not found
make: *** [Makefile:65: build] Error 127

the Makefile command looks good to me, so i'm not quite sure what is causing this but i'll keep poking around.

edit:
i guess we will need to add @displague to the openshift org or something to correct the owners issue. i will ask around about this.

- API types - basic controller/actuator scaffolding - basic reconciliation of Machine resources

JoelSpeed · 2021-01-14T13:22:25Z

displague
User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

Well that should have been fixed, will chase 🤔

displague · 2021-01-14T17:08:22Z

/verify-owners

elmiko · 2021-01-14T18:19:58Z

with the updated Makefile changes in place i was able to build the binary and run the unit tests. i hit a couple failures in the tests, doing some investigation to make sure i didn't miss something.

detiber · 2021-01-14T18:46:59Z

@elmiko The tests are likely pretty broken, most of them where copy/paste from another provider. I'm going to start digging into those to fix them up and mock out the api service for the unit style tests.

elmiko · 2021-01-14T19:00:49Z

@elmiko The tests are likely pretty broken, most of them where copy/paste from another provider. I'm going to start digging into those to fix them up and mock out the api service for the unit style tests.

ok cool, i'll focus more on reviewing the implementation details for now then. thanks for the heads up!

…t machineset functionality

displague · 2021-04-08T20:47:26Z

I'm starting to adapt the installer to take advantage of Metros. It would be great to see that introduced here - I suspect the dependencies will need to be revisited too.

elmiko · 2021-04-08T21:30:32Z

@displague i am not familiar with Metros, do you have a link or something i could catch up on?

displague · 2021-04-12T13:06:46Z

@elmiko https://feedback.equinixmetal.com/changelog/new-metros-feature-live

crawford · 2021-04-14T18:46:42Z

Hey @elmiko, is there anything else you'd like to see changed before merging? We were hoping to merge this as is and then follow up with support for Metros later (it's dependent on some changes to the installer).

displague · 2021-04-14T18:53:41Z

I realized that the installer, which is using the legacy Packet TF provider, would need to use the Equinix Metal TF provider. The EM provider is not an https://github.com/hashicorp/ provider (as Packet was). I don't believe I can use the EM TF provider until openshift/installer#4837 is merged.

The Packet provider will not be getting metro support, so I can't take advantage of metros even if this cluster-api provider included it.

elmiko · 2021-04-14T19:03:15Z

@crawford i have no specific requests at this time, but i haven't been able to test this code deeply. that said, i don't think my slowness here should be a blocker. i would like to have an opportunity to review more before we start packaging this as a supportable platform though.

openshift-bot · 2021-07-14T20:16:58Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-08-14T00:05:33Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

displague · 2021-08-19T12:52:19Z

/remove-lifecycle rotten

openshift-bot · 2021-11-17T15:40:37Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-12-17T16:20:13Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2022-01-16T16:31:02Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2022-01-16T16:31:04Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2020

openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 12, 2020

detiber force-pushed the metal branch from ce01f0f to 5a1f989 Compare October 14, 2020 19:21

detiber force-pushed the metal branch 3 times, most recently from 7ff7603 to f4a6ae1 Compare November 13, 2020 18:23

detiber mentioned this pull request Nov 13, 2020

API types and basic controller/actuator scaffolding #2

Closed

detiber changed the title ~~[WIP] start work on equinix metal provider~~ Start work on equinix metal provider Nov 13, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020

displague mentioned this pull request Nov 13, 2020

[WIP] Add the Packet provider openshift/installer#3914

Closed

6 tasks

displague reviewed Nov 17, 2020

View reviewed changes

Comment thread go.mod Outdated

detiber force-pushed the metal branch from f4a6ae1 to 512a178 Compare November 17, 2020 16:28

displague mentioned this pull request Dec 10, 2020

Add the Equinix Metal provider openshift/installer#4472

Closed

6 tasks

displague reviewed Jan 5, 2021

View reviewed changes

Comment thread example/worker-machine.yaml Outdated

detiber force-pushed the metal branch from 512a178 to 20f599b Compare January 6, 2021 15:05

detiber mentioned this pull request Jan 13, 2021

Add support for Equinix Metal openshift/cloud-credential-operator#283

Closed

Initial minimal implemenatation

339d30c

- API types - basic controller/actuator scaffolding - basic reconciliation of Machine resources

detiber force-pushed the metal branch from fdfcd3f to 339d30c Compare January 13, 2021 21:11

openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 14, 2021

elmiko reviewed Jan 14, 2021

View reviewed changes

Comment thread Makefile Outdated

elmiko reviewed Jan 14, 2021

View reviewed changes

Comment thread Makefile Outdated

elmiko reviewed Jan 14, 2021

View reviewed changes

Comment thread OWNERS

displague mentioned this pull request Jan 14, 2021

[WIP] Equinix Provider juju/juju#12349

Closed

detiber added 2 commits January 14, 2021 17:04

Enable mocking of client for testing, start fixing up tests, implemen…

8204e8a

…t machineset functionality

fix up api_key value to match cloud-credential-operator PR

12193ec

Add metro support

221248e

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2021

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 14, 2021

openshift-ci Bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 19, 2021

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2021

openshift-ci Bot closed this Jan 16, 2022

Conversation

detiber commented Oct 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

detiber commented Oct 12, 2020

Uh oh!

openshift-ci-robot commented Oct 12, 2020

Uh oh!

Uh oh!

JoelSpeed commented Nov 19, 2020

Uh oh!

detiber commented Nov 24, 2020

Uh oh!

JoelSpeed commented Nov 25, 2020

Uh oh!

Uh oh!

elmiko commented Jan 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoelSpeed commented Jan 14, 2021

Uh oh!

displague commented Jan 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elmiko commented Jan 14, 2021

Uh oh!

detiber commented Jan 14, 2021

Uh oh!

elmiko commented Jan 14, 2021

Uh oh!

displague commented Apr 8, 2021

Uh oh!

elmiko commented Apr 8, 2021

Uh oh!

displague commented Apr 12, 2021

Uh oh!

crawford commented Apr 14, 2021

Uh oh!

displague commented Apr 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elmiko commented Apr 14, 2021

Uh oh!

openshift-bot commented Jul 14, 2021

Uh oh!

openshift-bot commented Aug 14, 2021

Uh oh!

displague commented Aug 19, 2021

Uh oh!

openshift-bot commented Nov 17, 2021

Uh oh!

openshift-bot commented Dec 17, 2021

Uh oh!

openshift-bot commented Jan 16, 2022

Uh oh!

openshift-ci Bot commented Jan 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

detiber commented Oct 12, 2020 •

edited

Loading

elmiko commented Jan 12, 2021 •

edited

Loading

displague commented Apr 14, 2021 •

edited

Loading