upgrade terraform to 0.14.6#4837
Conversation
Update terraform-provider-aws to 3.1.0 Update terraform-provider-azure to 2.48.0 Update terraform-provider-google to 3.40.0
Update plugin directory to use new terraform plugin paths. Add environment variable that sets location of terraform.rc so that local terraform plugins can be used. New terraform provider requirements are documented here: https://www.terraform.io/docs/language/providers/requirements.html
Add terraform.rc and update terraform modules to specify terraform version and local provider locations.
Terraform 0.13 has a module count feature that can be set to instruct terraform to create the exact number of copies of the module in the cloud provider. This feature can be used to control the creation and deletion of the bootstrap resources needed for cluster. Adding the count field in all the bootstrap modules of all cloud providers in order to make it easy to destroy bootstrap after nodes have been created. This field would also make it easy to destroy the resources without having to check for the cloud platform and have a separate destroy logic for each of the platforms.
staebler
force-pushed
the
update_terraform
branch
from
b047ff1 to
6e2ae4f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-gcp |
|
/retest |
|
/test e2e-vsphere |
|
/test e2e-vsphere |
|
The ovirt install is failing to delete the template during bootstrap destroy. |
|
Failures with pip. |
|
For the ovirt, I was trying to remove this case statement by adding the boostrapping variable to the components. |
|
The ovirt install is also deleting the master VMs during bootstrap destroy. Presumably that is because it is deleting the template, which the master VMs depend upon. |
With terraform v0.14, deleting the temporary VM cascades to deletes of the final template and the master VMs, since there are dependencies between them. For the short-term, do not delete the temporary VM.
I added a commit that retains the temporary template. This is a workaround that I will raise a BZ for the ovirt team to address. |
|
/test e2e-gcp |
|
@staebler: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci-robot
added
the
needs-rebase
|
@staebler: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
|
@staebler: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This updates the installer to use Terraform 0.14.6.
Terraform 0.13.x updated the on-disk layout of the plugins directory, how to access offline plugins, and a lock file used for plugin versions. plugin_versions_generate.go has been added which generates plugin_versions.go. All terraform plugin files the installer uses have been updated to use the plugin version. All terraform config files have been updated to use the local providers. A terraform.rc file has been added to specify where the local providers are.
A temporary vendor path for terraform is in this PR that allows the location of the new plugin version lock file to be overridden. Once I can get everything green it will be added to our local terraform fork.
https://issues.redhat.com/browse/CORS-1520
https://www.terraform.io/docs/language/providers/requirements.html
https://www.terraform.io/docs/language/dependency-lock.html
This brings together the changes from #4729 and #4822.
/cc @jhixson74 @rna-afk