Skip to content

Conversation

@mandre
Copy link
Member

@mandre mandre commented Feb 2, 2022

There is a known issue with Cisco ACI [1] that causes the query to
return subnets that don't belong to the specified network. We can
workaround it and ensure the subnets really belong to the network.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2027305

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@mandre: This pull request references Bugzilla bug 2033862, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

Bug 2033862: Ensure subnets belong to the queried network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 2, 2022
@openshift-ci openshift-ci bot requested review from mdbooth and stephenfin February 2, 2022 14:53
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@mandre: This pull request references Bugzilla bug 2033862, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

In response to this:

Bug 2033862: Ensure subnets belong to the queried network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

There is a known issue with Cisco ACI [1] that causes the query to
return subnets that don't belong to the specified network. We can
workaround it and ensure the subnets really belong to the network.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2027305
@mandre mandre force-pushed the deduplicate-ports branch from cbf3c9c to b953986 Compare February 2, 2022 16:44
@EmilienM
Copy link
Member

EmilienM commented Feb 2, 2022

/lgtm
/approve
/hold for CI

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@mandre: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member

EmilienM commented Feb 2, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit b6018be into openshift:master Feb 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@mandre: All pull requests linked via external trackers have merged:

Bugzilla bug 2033862 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2033862: Ensure subnets belong to the queried network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Feb 3, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot

@mandre: new pull request created: #219

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the deduplicate-ports branch February 8, 2022 09:05
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
the openstackproviderspec removed in openshift#193 and
because of missing 'metav1.ObjectMeta' so it failed to
generate the CRD file.

Fixes openshift#217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants