Skip to content

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Jul 23, 2021

In separate commits, replace a function definition with the corresponding one that was made available in the latest release of gophercloud/utils, and adapt the code to the other changes in Gophercloud.

@openshift-ci openshift-ci bot requested review from EmilienM and mandre July 23, 2021 09:18
Remove an internally-defined function that is present in the latest
release of gophercloud/utils.
servergroups.List has changed its signature.
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit d675717 into openshift:master Jul 23, 2021
@pierreprinetti pierreprinetti deleted the bump_gophercloud branch July 23, 2021 15:52
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
the openstackproviderspec removed in openshift#193 and
because of missing 'metav1.ObjectMeta' so it failed to
generate the CRD file.

Fixes openshift#217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants